From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20001 invoked by alias); 20 May 2014 19:45:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19991 invoked by uid 89); 20 May 2014 19:45:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 20 May 2014 19:45:46 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 44.CE.27529.7316B735; Tue, 20 May 2014 16:05:43 +0200 (CEST) Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC002.ericsson.se ([147.117.188.78]) with mapi id 14.03.0174.001; Tue, 20 May 2014 15:45:43 -0400 From: Marc Khouzam To: 'Pedro Alves' , "'gdb-patches@sourceware.org'" Subject: RE: [PATCH] PR breakpoints/15697: Remove =breakpoint-modified when hitting dprintf Date: Tue, 20 May 2014 19:45:00 -0000 Message-ID: References: <1398716623-16991-1-git-send-email-marc.khouzam@ericsson.com> <535FDAB3.7010601@redhat.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00443.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Marc Khouzam > Sent: Tuesday, April 29, 2014 1:48 PM > To: 'Pedro Alves' > Cc: 'gdb-patches@sourceware.org' > Subject: RE: [PATCH] PR breakpoints/15697: Remove =3Dbreakpoint-modified > when hitting dprintf >=20 > > -----Original Message----- > > From: Pedro Alves [mailto:palves@redhat.com] > > Sent: Tuesday, April 29, 2014 1:01 PM > > To: Marc Khouzam > > Cc: gdb-patches@sourceware.org > > Subject: Re: [PATCH] PR breakpoints/15697: Remove =3Dbreakpoint-modified > > when hitting dprintf >=20 > [Bunch of very valid concerns] >=20 > > Related, I'm not sure we should filter the > > observer_notify_breakpoint_modified call -- it would seem better if > > observers are notified, and the its MI that filters out those > > modifications that it isn't interested in. > > E.g., could TUI be interested in still receiving the nofications? >=20 > Something to think about. Simon made the same comment off-line. >=20 > > I don't have answers to the above, but I think these issues all need > > to be considered, and whatever resolutions we end up with need to be > > cast as comments in the code and manual. >=20 > Thanks Pedro, you are bringing up valid (and tricky :-)) points. I'll lo= ok into > them and see if I can come up with equally valid solutions. To follow up on this. After discussing with Pedro offline, he helped point= -out that the many =3Dbreakpoint-modified notifications were not actually causing any problems to Eclipse. The issue was actually in the corresponding extra *running event. Pedro has already followed-up on a fix for the *running event here (thanks!= ): https://sourceware.org/ml/gdb-patches/2014-05/msg00273.html And I'm dropping this patch, as it is not helpful. Thanks Marc