Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Abhijit Halder <abhijit.k.halder@gmail.com>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org,
	sergiodj@redhat.com, jan.kratochvil@redhat.com,
	tromey@redhat.com
Subject: Re: [PATCH][TEST-CASE][DOC] Implementation of pipe to pass GDB's command output to the shell.
Date: Wed, 31 Aug 2011 11:01:00 -0000	[thread overview]
Message-ID: <E1QyiXJ-0006Oi-VO@fencepost.gnu.org> (raw)
In-Reply-To: <CAOhZP9y2tkbMNN9BmB-oWn0dH4PaXT2_xM5unG5Puumc_=6-rw@mail.gmail.com>	(message from Abhijit Halder on Wed, 31 Aug 2011 14:13:49 +0530)

> Date: Wed, 31 Aug 2011 14:13:49 +0530
> From: Abhijit Halder <abhijit.k.halder@gmail.com>
> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, sergiodj@redhat.com, 
> 	jan.kratochvil@redhat.com, tromey@redhat.com
> 
> >> +@samp{print dd_tbl} is passed to the shell command @samp{sed 's/@}/\n/g' | @
> >> +grep ".test_dd" | tr ',' '\n'} for processing.
> >
> > I would suggest to add that the example does not use `|' as a
> > delimiter to allow the shell command to use it in its usual shell
> > semantics.
> >
> In the above example one can use `|' as the delimiter. it will not
> break anything syntactically but will not be readable much, hence I
> avoided using `|' as delimiter. Do we need to mention that here?

We don't _have_ to mention that, but I think it's a good idea, because
the natural choice of the delimiter is the normal pipe character.

> I made the corrections as suggested. Please review this:

OK, thanks.


  reply	other threads:[~2011-08-31 11:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 11:43 Abhijit Halder
2011-08-26 12:18 ` Eli Zaretskii
2011-08-28  8:52   ` Abhijit Halder
2011-08-28  9:25     ` Eli Zaretskii
2011-08-28  9:51     ` Eli Zaretskii
2011-08-28 10:12       ` Eli Zaretskii
2011-08-30 13:58         ` Abhijit Halder
2011-08-30 14:27           ` Pedro Alves
2011-08-30 14:32             ` Abhijit Halder
2011-08-30 14:49               ` Abhijit Halder
2011-08-30 16:38                 ` Abhijit Halder
2011-08-30 18:07                   ` Eli Zaretskii
2011-08-31  8:44                     ` Abhijit Halder
2011-08-31 11:01                       ` Eli Zaretskii [this message]
2011-08-31 12:42                         ` Abhijit Halder
2011-08-31 13:26                           ` Eli Zaretskii
2011-08-30 18:09                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1QyiXJ-0006Oi-VO@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=abhijit.k.halder@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pedro@codesourcery.com \
    --cc=sergiodj@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox