From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83391-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23336 invoked by alias); 31 Aug 2011 11:01:06 -0000
Received: (qmail 23322 invoked by uid 22791); 31 Aug 2011 11:01:05 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 11:00:51 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1QyiXJ-0006Oi-VO; Wed, 31 Aug 2011 07:00:50 -0400
Date: Wed, 31 Aug 2011 11:01:00 -0000
Message-Id: <E1QyiXJ-0006Oi-VO@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Abhijit Halder <abhijit.k.halder@gmail.com>
CC: pedro@codesourcery.com, gdb-patches@sourceware.org,	sergiodj@redhat.com, jan.kratochvil@redhat.com,	tromey@redhat.com
In-reply-to:	<CAOhZP9y2tkbMNN9BmB-oWn0dH4PaXT2_xM5unG5Puumc_=6-rw@mail.gmail.com>	(message from Abhijit Halder on Wed, 31 Aug 2011 14:13:49 +0530)
Subject: Re: [PATCH][TEST-CASE][DOC] Implementation of pipe to pass GDB's command output to the shell.
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <CAOhZP9wvFrF3z8SHSjot7grMtrkGcwFzXh8Te=qaA=1P4eYuFw@mail.gmail.com>	<E1QxcLM-00006e-79@fencepost.gnu.org>	<CAOhZP9xPqoGx8wV8=JRsvVS2jMEtOhu8NZ8RUeQ4DN+1KOfbzg@mail.gmail.com>	<201108301527.22683.pedro@codesourcery.com>	<CAOhZP9yec-9MgFL1waa2Gm6xSqozFc3R=Gt9x-t81uXBq9iDOg@mail.gmail.com>	<CAOhZP9y7mw4pOpWhitSHR1MuGjtb02D7Z1wFgiqkPnjhFVrUvg@mail.gmail.com>	<CAOhZP9xsc2Q+7FapkWHcWv9TZihF1QBQJDgrLBTBjNbaHBu-og@mail.gmail.com>	<83y5yaepu4.fsf@gnu.org> <CAOhZP9y2tkbMNN9BmB-oWn0dH4PaXT2_xM5unG5Puumc_=6-rw@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00651.txt.bz2

> Date: Wed, 31 Aug 2011 14:13:49 +0530
> From: Abhijit Halder <abhijit.k.halder@gmail.com>
> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, sergiodj@redhat.com, 
> 	jan.kratochvil@redhat.com, tromey@redhat.com
> 
> >> +@samp{print dd_tbl} is passed to the shell command @samp{sed 's/@}/\n/g' | @
> >> +grep ".test_dd" | tr ',' '\n'} for processing.
> >
> > I would suggest to add that the example does not use `|' as a
> > delimiter to allow the shell command to use it in its usual shell
> > semantics.
> >
> In the above example one can use `|' as the delimiter. it will not
> break anything syntactically but will not be readable much, hence I
> avoided using `|' as delimiter. Do we need to mention that here?

We don't _have_ to mention that, but I think it's a good idea, because
the natural choice of the delimiter is the normal pipe character.

> I made the corrections as suggested. Please review this:

OK, thanks.