Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Somewhat sanitize watchpoints with conditions on local expressions
Date: Thu, 04 Mar 2010 07:55:00 -0000	[thread overview]
Message-ID: <E1Nn5u2-0006TS-0i@fencepost.gnu.org> (raw)
In-Reply-To: <201003040350.34417.pedro@codesourcery.com> (message from Pedro 	Alves on Thu, 4 Mar 2010 03:50:34 +0000)

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Thu, 4 Mar 2010 03:50:34 +0000
> 
> The patch below that implements what sounded least
> surprising to me (evaluate condition in correct frame
> if possible, and warn if not possible, without trying
> and doing undefined things), and adds tests
> for this, and other variants involving global
> expressions, and local conditions.
> 
> 
> Comments?

I like it.  One question:

> +static int
> +is_watchpoint (struct breakpoint *bpt)
> +{
> +  return (is_hardware_watchpoint (bpt)
> +	  || bpt->type == bp_watchpoint);
> +}

Does this catch read and access watchpoints?  Should it?

Thanks.


  parent reply	other threads:[~2010-03-04  7:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04  3:50 Pedro Alves
2010-03-04  5:59 ` Joel Brobecker
2010-03-04  7:57   ` Eli Zaretskii
2010-03-04 16:00   ` Pedro Alves
2010-03-04 16:12     ` Pedro Alves
2010-03-04 16:19       ` Pedro Alves
2010-03-04 16:23         ` Pedro Alves
2010-03-08  6:34         ` Joel Brobecker
2010-03-10 13:27         ` Pedro Alves
2010-03-04  7:55 ` Eli Zaretskii [this message]
2010-03-04 16:05   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Nn5u2-0006TS-0i@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox