From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Somewhat sanitize watchpoints with conditions on local expressions
Date: Mon, 08 Mar 2010 06:34:00 -0000 [thread overview]
Message-ID: <20100308063348.GD3081@adacore.com> (raw)
In-Reply-To: <201003041618.59734.pedro@codesourcery.com>
> 2010-03-04 Pedro Alves <pedro@codesourcery.com>
>
> gdb/
> * breakpoint.c (condition_command): Handle watchpoint conditions.
> (is_hardware_watchpoint): Add comment.
> (is_watchpoint): New.
> (update_watchpoint): Don't reparse the watchpoint's condition
> unless necessary.
> (WP_IGNORE): New.
> (watchpoint_check): Use it.
> (bpstat_check_watchpoint): Handle it.
> (bpstat_check_breakpoint_conditions): Evaluate watchpoint local
> conditions in a frame where it makes sense.
> (watch_command_1): Store the innermost block of the condition
> expression.
> (delete_breakpoint): Delete the watchpoint condition expression.
> * breakpoint.h (struct bp_location) <cond>: Update comment.
> (struct breakpoint): New field `cond_exp_valid_block'.
>
> gdb/testsuite/
> * gdb.base/watch-cond.c, gdb.base/watch-cond.exp: New.
FWIW, this looks fine to me. And after discussion, I agree it seems
much better to always stop rather than disable the watchpoint when
the condition can no longer be evaluated in the current scope.
--
Joel
next prev parent reply other threads:[~2010-03-08 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 3:50 Pedro Alves
2010-03-04 5:59 ` Joel Brobecker
2010-03-04 7:57 ` Eli Zaretskii
2010-03-04 16:00 ` Pedro Alves
2010-03-04 16:12 ` Pedro Alves
2010-03-04 16:19 ` Pedro Alves
2010-03-04 16:23 ` Pedro Alves
2010-03-08 6:34 ` Joel Brobecker [this message]
2010-03-10 13:27 ` Pedro Alves
2010-03-04 7:55 ` Eli Zaretskii
2010-03-04 16:05 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308063348.GD3081@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox