[gnu-nat] PATCH (part of PR #2534) s/current_inferior/gnu_current_inf/g

[gnu-nat] PATCH (part of PR #2534) s/current_inferior/gnu_current_inf/g

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hi,

This patch renames current_inferior in gnu-nat.c and friends to
avoid the collision with the new function of the same name recently
added to GDB's core.

I had this change here locally since the time I had introduced the
new function, but delayed in posting it.  End result, Thomas Schwinge
had to go through the same thing, and posted this patch on PR 2534.

Sorry for the extra work Thomas.  :-(

I've just tweaked the patch by adding a gnu_ prefix to the variable,
as I believe it's the target's responsability to keep it's namespace
clean.

OK ?

-- 
Pedro Alves

[-- Attachment #2: gnu_current_inferior.diff --]
[-- Type: text/x-diff, Size: 7568 bytes --]

2008-10-07  Thomas Schwinge  <tschwinge@gnu.org>
	    Pedro Alves  <pedro@codesourcery.com>

	* gnu-nat.h: Rename `current_inferior' to `gnu_current_inf' to
	avoid a name collision.
	* gnu-nat.c: Likewise.
	* i386gnu-nat.c: Likewise.

---
 gdb/gnu-nat.c     |   56 +++++++++++++++++++++++++++---------------------------
 gdb/gnu-nat.h     |    2 -
 gdb/i386gnu-nat.c |    8 +++----
 3 files changed, 33 insertions(+), 33 deletions(-)

Index: src/gdb/gnu-nat.c
===================================================================
--- src.orig/gdb/gnu-nat.c	2008-09-27 22:44:36.000000000 +0100
+++ src/gdb/gnu-nat.c	2008-10-07 12:49:44.000000000 +0100
@@ -1425,7 +1425,7 @@ inf_continue (struct inf *inf)
 
 \f
 /* The inferior used for all gdb target ops.  */
-struct inf *current_inferior = 0;
+struct inf *gnu_current_inf = 0;
 
 /* The inferior being waited for by gnu_wait.  Since GDB is decidely not
    multi-threaded, we don't bother to lock this.  */
@@ -1443,7 +1443,7 @@ gnu_wait (ptid_t ptid, struct target_wai
     } msg;
   error_t err;
   struct proc *thread;
-  struct inf *inf = current_inferior;
+  struct inf *inf = gnu_current_inf;
 
   extern int exc_server (mach_msg_header_t *, mach_msg_header_t *);
   extern int msg_reply_server (mach_msg_header_t *, mach_msg_header_t *);
@@ -1958,7 +1958,7 @@ gnu_resume (ptid_t ptid, int step, enum 
 {
   struct proc *step_thread = 0;
   int resume_all;
-  struct inf *inf = current_inferior;
+  struct inf *inf = gnu_current_inf;
 
   inf_debug (inf, "ptid = %s, step = %d, sig = %d",
 	     target_pid_to_str (ptid), step, sig);
@@ -2030,12 +2030,12 @@ gnu_resume (ptid_t ptid, int step, enum 
 static void
 gnu_kill_inferior (void)
 {
-  struct proc *task = current_inferior->task;
+  struct proc *task = gnu_current_inf->task;
   if (task)
     {
       proc_debug (task, "terminating...");
       task_terminate (task->port);
-      inf_set_pid (current_inferior, -1);
+      inf_set_pid (gnu_current_inf, -1);
     }
   target_mourn_inferior ();
 }
@@ -2044,8 +2044,8 @@ gnu_kill_inferior (void)
 static void
 gnu_mourn_inferior (void)
 {
-  inf_debug (current_inferior, "rip");
-  inf_detach (current_inferior);
+  inf_debug (gnu_current_inf, "rip");
+  inf_detach (gnu_current_inf);
   unpush_target (&gnu_ops);
   generic_mourn_inferior ();
 }
@@ -2057,9 +2057,9 @@ gnu_mourn_inferior (void)
 static int
 inf_pick_first_thread (void)
 {
-  if (current_inferior->task && current_inferior->threads)
+  if (gnu_current_inf->task && gnu_current_inf->threads)
     /* The first thread.  */
-    return current_inferior->threads->tid;
+    return gnu_current_inf->threads->tid;
   else
     /* What may be the next thread.  */
     return next_thread_id;
@@ -2068,9 +2068,9 @@ inf_pick_first_thread (void)
 static struct inf *
 cur_inf (void)
 {
-  if (!current_inferior)
-    current_inferior = make_inf ();
-  return current_inferior;
+  if (!gnu_current_inf)
+    gnu_current_inf = make_inf ();
+  return gnu_current_inf;
 }
 
 static void
@@ -2214,15 +2214,15 @@ gnu_detach (char *args, int from_tty)
       char *exec_file = get_exec_file (0);
       if (exec_file)
 	printf_unfiltered ("Detaching from program `%s' pid %d\n",
-			   exec_file, current_inferior->pid);
+			   exec_file, gnu_current_inf->pid);
       else
-	printf_unfiltered ("Detaching from pid %d\n", current_inferior->pid);
+	printf_unfiltered ("Detaching from pid %d\n", gnu_current_inf->pid);
       gdb_flush (gdb_stdout);
     }
 
-  pid = current_inferior->pid;
+  pid = gnu_current_inf->pid;
 
-  inf_detach (current_inferior);
+  inf_detach (gnu_current_inf);
 
   inferior_ptid = null_ptid;
   detach_inferior (pid);
@@ -2233,8 +2233,8 @@ gnu_detach (char *args, int from_tty)
 static void
 gnu_terminal_init_inferior (void)
 {
-  gdb_assert (current_inferior);
-  terminal_init_inferior_with_pgrp (current_inferior->pid);
+  gdb_assert (gnu_current_inf);
+  terminal_init_inferior_with_pgrp (gnu_current_inf->pid);
 }
 
 /* Get ready to modify the registers array.  On machines which store
@@ -2262,8 +2262,8 @@ gnu_stop (ptid_t ptid)
 static int
 gnu_thread_alive (ptid_t ptid)
 {
-  inf_update_procs (current_inferior);
-  return !!inf_tid_to_thread (current_inferior,
+  inf_update_procs (gnu_current_inf);
+  return !!inf_tid_to_thread (gnu_current_inf,
 			      ptid_get_tid (ptid));
 }
 
@@ -2478,16 +2478,16 @@ gnu_xfer_memory (CORE_ADDR memaddr, gdb_
 		 struct mem_attrib *attrib,
 		 struct target_ops *target)
 {
-  task_t task = (current_inferior
-		 ? (current_inferior->task
-		    ? current_inferior->task->port : 0)
+  task_t task = (gnu_current_inf
+		 ? (gnu_current_inf->task
+		    ? gnu_current_inf->task->port : 0)
 		 : 0);
 
   if (task == MACH_PORT_NULL)
     return 0;
   else
     {
-      inf_debug (current_inferior, "%s %p[%d] %s %p",
+      inf_debug (gnu_current_inf, "%s %p[%d] %s %p",
 		 write ? "writing" : "reading", (void *) memaddr, len,
 		 write ? "<--" : "-->", myaddr);
       if (write)
@@ -2510,9 +2510,9 @@ gnu_find_memory_regions (int (*func) (CO
   vm_address_t region_address, last_region_address, last_region_end;
   vm_prot_t last_protection;
 
-  if (current_inferior == 0 || current_inferior->task == 0)
+  if (gnu_current_inf == 0 || gnu_current_inf->task == 0)
     return 0;
-  task = current_inferior->task->port;
+  task = gnu_current_inf->task->port;
   if (task == MACH_PORT_NULL)
     return 0;
 
@@ -2595,7 +2595,7 @@ proc_string (struct proc *proc)
 static char *
 gnu_pid_to_str (ptid_t ptid)
 {
-  struct inf *inf = current_inferior;
+  struct inf *inf = gnu_current_inf;
   int tid = ptid_get_tid (ptid);
   struct proc *thread = inf_tid_to_thread (inf, tid);
 
@@ -3423,7 +3423,7 @@ flush_inferior_icache (CORE_ADDR pc, int
   vm_machine_attribute_val_t flush = MATTR_VAL_ICACHE_FLUSH;
   error_t ret;
 
-  ret = vm_machine_attribute (current_inferior->task->port,
+  ret = vm_machine_attribute (gnu_current_inf->task->port,
 			      pc,
 			      amount,
 			      MATTR_CACHE,
Index: src/gdb/gnu-nat.h
===================================================================
--- src.orig/gdb/gnu-nat.h	2008-10-07 12:50:11.000000000 +0100
+++ src/gdb/gnu-nat.h	2008-10-07 12:50:26.000000000 +0100
@@ -25,7 +25,7 @@
 
 struct inf;
 
-extern struct inf *current_inferior;
+extern struct inf *gnu_current_inf;
 
 /* Converts a GDB pid to a struct proc.  */
 struct proc *inf_tid_to_thread (struct inf *inf, int tid);
Index: src/gdb/i386gnu-nat.c
===================================================================
--- src.orig/gdb/i386gnu-nat.c	2008-10-07 12:50:55.000000000 +0100
+++ src/gdb/i386gnu-nat.c	2008-10-07 12:51:26.000000000 +0100
@@ -116,9 +116,9 @@ gnu_fetch_registers (struct regcache *re
   struct proc *thread;
 
   /* Make sure we know about new threads.  */
-  inf_update_procs (current_inferior);
+  inf_update_procs (gnu_current_inf);
 
-  thread = inf_tid_to_thread (current_inferior,
+  thread = inf_tid_to_thread (gnu_current_inf,
 			      ptid_get_tid (inferior_ptid));
   if (!thread)
     error (_("Can't fetch registers from thread %s: No such thread"),
@@ -208,9 +208,9 @@ gnu_store_registers (struct regcache *re
   struct gdbarch *gdbarch = get_regcache_arch (regcache);
 
   /* Make sure we know about new threads.  */
-  inf_update_procs (current_inferior);
+  inf_update_procs (gnu_current_inf);
 
-  thread = inf_tid_to_thread (current_inferior,
+  thread = inf_tid_to_thread (gnu_current_inf,
 			      ptid_get_tid (inferior_ptid));
   if (!thread)
     error (_("Couldn't store registers into thread %s: No such thread"),

Re: [gnu-nat] PATCH (part of PR #2534) s/current_inferior/gnu_current_inf/g

[Alfred M. Szmidt]

   Sorry for the extra work Thomas.  :-(

I must have missed the PR 2534 patch, do patches submited through
bugzilla go to the mailing list?

   OK ?

OK, thank you very much Pedro for your work.

Re: [gnu-nat] PATCH (part of PR #2534) s/current_inferior/gnu_current_inf/g

[Pedro Alves]

On Tuesday 07 October 2008 19:00:41, Alfred M. Szmidt wrote:
>    Sorry for the extra work Thomas.  :-(
> 
> I must have missed the PR 2534 patch, do patches submited through
> bugzilla go to the mailing list?

If they do, I don't get them, only the messages.  Honestly, I can't
tell which mailing list is sending me the PR copies.  I seem to
get them through gdb-prs@, or maybe gdb-gnats@ ?

Note that there are a couple of patches more attached to
the PR.

> OK, thank you very much Pedro for your work.

Thanks.  I've installed it.

-- 
Pedro Alves

Re: [gnu-nat] PATCH (part of PR #2534) s/current_inferior/gnu_current_inf/g

[Alfred M. Szmidt]

   > I must have missed the PR 2534 patch, do patches submited through
   > bugzilla go to the mailing list?

   If they do, I don't get them, only the messages.  Honestly, I can't
   tell which mailing list is sending me the PR copies.  I seem to get
   them through gdb-prs@, or maybe gdb-gnats@ ?

   Note that there are a couple of patches more attached to the PR.

I will try and go through the tracker soon, seems I have missed a few
since I only keep a eye on gdb-patches.

[gnu-nat] PATCH (part of PR #2534)

[Thomas Schwinge]

[-- Attachment #1: gdb-2-BAD_TYPECHECK.patch --]
[-- Type: text/plain, Size: 972 bytes --]

2008-10-06  Thomas Schwinge  <tschwinge@gnu.org>

	* reply_mig_hack.awk: Use the `BAD_TYPECHECK' macro.

Index: reply_mig_hack.awk
===================================================================
RCS file: /cvs/src/src/gdb/reply_mig_hack.awk,v
retrieving revision 1.6
diff -u -p -r1.6 reply_mig_hack.awk
--- reply_mig_hack.awk	1 Jan 2008 22:53:12 -0000	1.6
+++ reply_mig_hack.awk	6 Oct 2008 08:42:50 -0000
@@ -101,7 +101,7 @@ parse_phase == 5 && /^#if[ \t]TypeCheck/
   # structure that we want to check for.
   print "\tif (In0P->Head.msgh_size == sizeof (Reply)";
   print "\t    && ! (In0P->Head.msgh_bits & MACH_MSGH_BITS_COMPLEX)";
-  print "\t    && *(int *)&In0P->" arg_type_code_name[0] " == *(int *)&" arg_check_name[0];
+  print "\t    && ! BAD_TYPECHECK(&In0P->" arg_type_code_name[0] ", &" arg_check_name[0] ")";
   print "\t    && In0P->" arg_name[0] " != 0)";
   print "\t  /* Error return, only the error code argument is passed.  */";
   print "\t  {";

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

[gnu-nat] PATCH (part of PR #2534)

[Thomas Schwinge]

[-- Attachment #1: gdb-3-werror.patch --]
[-- Type: text/plain, Size: 1056 bytes --]

2008-10-06  Thomas Schwinge  <tschwinge@gnu.org>

	* Makefile.in: Revert 2008-09-10 change, as the problem is fixed
	upstream.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1049
retrieving revision 1.1048
diff -u -p -r1.1049 -r1.1048
--- Makefile.in	10 Sep 2008 18:13:21 -0000	1.1049
+++ Makefile.in	20 Aug 2008 10:18:23 -0000	1.1048
@@ -1343,13 +1343,6 @@ ALLDEPFILES = \
 # Some files need explicit build rules (due to -Werror problems) or due
 # to sub-directory fun 'n' games.
 
-# "gnu-nat.c" gets "suggest parentheses around assignment used as
-# truth value" errors.  It turns out that there is a system header
-# that does `if (a = b)'.
-gnu-nat.o: $(srcdir)/gnu-nat.c
-	$(COMPILE.pre) $(INTERNAL_WARN_CFLAGS) $(COMPILE.post) $(srcdir)/gnu-nat.c
-	$(POSTCOMPILE)
-
 hpux-thread.o: $(srcdir)/hpux-thread.c
 	$(COMPILE) -I$(srcdir)/osf-share -I$(srcdir)/osf-share/HP800 \
 		-I/usr/include/dce $(srcdir)/hpux-thread.c

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

Re: [gnu-nat] PATCH (part of PR #2534)

[Thomas Schwinge]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

Hello!

On Wed, Oct 08, 2008 at 01:08:43AM +0200, I wrote:
> 2008-10-06  Thomas Schwinge  <tschwinge@gnu.org>
> 
> 	* reply_mig_hack.awk: Use the `BAD_TYPECHECK' macro.

Committed.


Regards,
 Thomas

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

Re: [gnu-nat] PATCH (part of PR #2534)

[Thomas Schwinge]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Hello!

On Wed, Oct 08, 2008 at 01:10:26AM +0200, I wrote:
> 2008-10-06  Thomas Schwinge  <tschwinge@gnu.org>
> 
> 	* Makefile.in: Revert 2008-09-10 change, as the problem is fixed
> 	upstream.

Committed.


Regards,
 Thomas

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

Re: [gnu-nat] PATCH (part of PR #2534)

[Alfred M. Szmidt]

Thanks.