From: Vladimir Prus <ghost@cs.msu.su>
To: Daniel Jacobowitz <drow@false.org>, gdb-patches@sources.redhat.com
Subject: Re: [mi] fix 'editable' attribute for references
Date: Wed, 24 Jan 2007 08:05:00 -0000 [thread overview]
Message-ID: <E1H9d8J-0004Qp-Vx@zigzag.lvk.cs.msu.su> (raw)
In-Reply-To: <20070120194548.GD22153@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Tue, Jan 16, 2007 at 10:06:30PM +0300, Vladimir Prus wrote:
>> Vladimir Prus wrote:
>>
>> >
>> > I've noticed that the -var-show-references returns 'attr=noneditable'
>> > for structures, but 'attr=editable' for references to structures, which
>> > makes no sense.
>>
>> I've also noticed that while for structures, we don't compare old
>> and new values, and never report varobj corresponding to structure as
>> changed, we do all that for references to structures. This patch fixes
>> both problems, OK?
>
> This is included in the C++ references patch I just reviewed, right?
Grr, right. I meant to post them as completely separate patches to ease review,
but messed that up and you've reviewed combined patch.
My only excuse is that I'll still commit those as separate patches, so that
at least the history is right.
- Volodya
next prev parent reply other threads:[~2007-01-24 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 18:39 Vladimir Prus
2007-01-16 19:06 ` Vladimir Prus
2007-01-20 19:45 ` Daniel Jacobowitz
2007-01-24 8:05 ` Vladimir Prus [this message]
2007-01-24 10:51 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1H9d8J-0004Qp-Vx@zigzag.lvk.cs.msu.su \
--to=ghost@cs.msu.su \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox