From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29379 invoked by alias); 24 Jan 2007 08:05:51 -0000 Received: (qmail 29371 invoked by uid 22791); 24 Jan 2007 08:05:50 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Jan 2007 08:05:46 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H9d8T-0004RD-KD for gdb-patches@sources.redhat.com; Wed, 24 Jan 2007 11:05:42 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1H9d8J-0004Qp-Vx; Wed, 24 Jan 2007 11:05:28 +0300 From: Vladimir Prus Subject: Re: [mi] fix 'editable' attribute for references To: Daniel Jacobowitz , gdb-patches@sources.redhat.com Date: Wed, 24 Jan 2007 08:05:00 -0000 References: <200701162138.39578.ghost@cs.msu.su> <20070120194548.GD22153@nevyn.them.org> User-Agent: KNode/0.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00493.txt.bz2 Daniel Jacobowitz wrote: > On Tue, Jan 16, 2007 at 10:06:30PM +0300, Vladimir Prus wrote: >> Vladimir Prus wrote: >> >> > >> > I've noticed that the -var-show-references returns 'attr=noneditable' >> > for structures, but 'attr=editable' for references to structures, which >> > makes no sense. >> >> I've also noticed that while for structures, we don't compare old >> and new values, and never report varobj corresponding to structure as >> changed, we do all that for references to structures. This patch fixes >> both problems, OK? > > This is included in the C++ references patch I just reviewed, right? Grr, right. I meant to post them as completely separate patches to ease review, but messed that up and you've reviewed combined patch. My only excuse is that I'll still commit those as separate patches, so that at least the history is right. - Volodya