From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>, gdb-patches@sources.redhat.com
Subject: Re: MI: Another -var-update bug? [PATCH]
Date: Thu, 04 Jan 2007 18:49:00 -0000 [thread overview]
Message-ID: <E1H2Xe8-0007Mc-Ae@zigzag.lvk.cs.msu.su> (raw)
In-Reply-To: <17791.40309.90872.126841@kahikatea.snap.net.nz>
Nick Roberts wrote:
> Something like below?
This patch introduces this for me:
FAIL: gdb.mi/mi-var-cp.exp: update RX (3)
Do you get this failure to? If yes, can you please fix it?
If no, let me know and I'll investigate.
> /* FIXME: select_frame could fail */
> ! Â Â Â if (fi)
> ! Â Â Â Â Â Â {
> ! Â Â Â Â Â Â Â CORE_ADDR pc = get_frame_pc (fi);
> ! Â Â Â Â Â Â Â if (pc < Â BLOCK_START (var->root->valid_block) ||
> ! Â Â Â Â Â Â Â Â Â pc >= BLOCK_END (var->root->valid_block))
> ! Â Â Â Â Â Â Â Â within_scope = 0;
> ! Â Â Â Â Â Â Â select_frame (fi);
> ! Â Â Â Â Â Â }
The code later in this function is only executed if "within_scope" is
true. Would it be better to call select_frame only if within_scope is
set to true, like this:
if (pc < BLOCK_START (var->root->valid_block) ||
pc >= BLOCK_END (var->root->valid_block))
within_scope = 0;
else
select_frame (fi);
?
- Volodya
next prev parent reply other threads:[~2007-01-04 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 11:09 MI: Another -var-update bug? Nick Roberts
2006-12-13 6:32 ` MI: Another -var-update bug? [PATCH] Nick Roberts
2006-12-30 15:06 ` Daniel Jacobowitz
2006-12-30 22:43 ` Nick Roberts
2006-12-31 2:19 ` Daniel Jacobowitz
2007-01-01 16:24 ` Daniel Jacobowitz
2007-01-01 22:13 ` Nick Roberts
2007-01-04 18:51 ` Vladimir Prus
2007-01-04 19:43 ` Nick Roberts
2007-01-04 18:49 ` Vladimir Prus [this message]
2007-01-04 23:59 ` Nick Roberts
2007-01-05 9:10 ` Vladimir Prus
2007-01-05 15:10 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1H2Xe8-0007Mc-Ae@zigzag.lvk.cs.msu.su \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox