Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aditya Kamath <Aditya.Kamath1@ibm.com>
To: Tom Tromey <tom@tromey.com>,
	Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	"simon.marchi@polymtl.ca" <simon.marchi@polymtl.ca>,
	"tom@tromey.com" <tom@tromey.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>
Subject: RE: [PATCH] Use UTF-32 as the wide charset for 64-bit
Date: Wed, 21 Oct 2026 06:32:55 +0000	[thread overview]
Message-ID: <DSWPR15MB3198178650CB640469138A362ED6662@DSWPR15MB319817.namprd15.prod.outlook.com> (raw)
In-Reply-To: <87v76x1xu6.fsf@tromey.com>

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Hi Tom and community members,

>>  static const char *
>> -rs6000_aix_auto_wide_charset (void)
>> +rs6000_aix_auto_wide_charset_32 (void)

>Could you remove the 'void' here?

>> +static const char *
>> +rs6000_aix_auto_wide_charset_64 (void)

>Here too?

>'void' is only needed here for C, it's an anachronism in the gdb code,
>so when touching one of these lines it's nice to remove it; and not to
>add new instances.

Thanks for the review, Tom. Pushed with this change.

https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6fd421ad78bcb259f371394498e2c1346380e5b7

Regards,
Aditya

[-- Attachment #2: Type: text/html, Size: 1913 bytes --]

      reply	other threads:[~2026-10-21  6:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 13:47 Aditya Vidyadhar Kamath
2026-10-15 14:05 ` Tom Tromey
2026-10-16 12:02   ` Aditya Kamath
2026-10-19 16:04 ` Tom Tromey
2026-10-21  6:32   ` Aditya Kamath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DSWPR15MB3198178650CB640469138A362ED6662@DSWPR15MB319817.namprd15.prod.outlook.com \
    --to=aditya.kamath1@ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox