Re: [PATCH] Use UTF-32 as the wide charset for 64-bit

[Tom Tromey <tom@tromey.com>]

>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> From: Aditya Vidyadhar Kamath <aditya.kamath1@ibm.com>
> On AIX, wchar_t is 4 bytes in 64-bit mode and 2 bytes in 32-bit mode,
> and rs6000_aix_init_osabi sets wchar_bit accordingly.  The
> auto_wide_charset method however always returned "UTF-16", so a 64-bit
> inferior's wide strings were decoded as 2-byte units.  This printed
> L'\000\000a' for L'a', and GDB crashed with SIGSEGV on the following
> print in gdb.base/wchar.exp.

> Return "UTF-32" for 64-bit and keep "UTF-16" for 32-bit.  wchar.exp now
> passes in 64-bit mode.

Thanks for the patch.

>  static const char *
> -rs6000_aix_auto_wide_charset (void)
> +rs6000_aix_auto_wide_charset_32 (void)

Could you remove the 'void' here?

> +static const char *
> +rs6000_aix_auto_wide_charset_64 (void)

Here too?

'void' is only needed here for C, it's an anachronism in the gdb code,
so when touching one of these lines it's nice to remove it; and not to
add new instances.

Ok with this change.
Approved-By: Tom Tromey <tom@tromey.com>

Tom