Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Aktemur, Baris" <TankutBaris.Aktemur@amd.com>
To: "simon.marchi@polymtl.ca" <simon.marchi@polymtl.ca>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 0/7] gdb/testsuite: allow passing inferior arguments with native-gdbserver board
Date: Mon, 15 Jun 2026 09:54:38 +0000	[thread overview]
Message-ID: <DM4PR12MB6470CA89C30F591601228078F8E62@DM4PR12MB6470.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM4PR12MB64700A4EEFA6A3D53BD5EA75F8392@DM4PR12MB6470.namprd12.prod.outlook.com>

AMD General

Hi Simon,

> > From: Simon Marchi <simon.marchi@polymtl.ca>
> >
> > I started looking into this while revieweing this patch from Baris [1].
> > The problem was that a set was attempting to pass args to the inferior
> > using "set args", which does not work with the native-gdbserver board.
> > I tried to implement proper support for passing arguments to inferior
> > programs in the testsuite, and this series is the result.
> >
> > [1] https://inbox.sourceware.org/20260424141955.4083734-1-
> > tankut.baris.aktemur%40intel.com
>
> Thank you for digging in and finding out a more fundamental issue.
>
> I looked at the series and it seemed fine to me.  I sent two minor
> comments to patches 3 and 4.
>
> Reviewed-By: Tankut Baris Aktemur <TankutBaris.Aktemur@amd.com>
>
> There is one improvement you could maybe consider:
> The new -inferior-args parameter to runto is used in places where
> there is only one argument is passed.  It may help future patch authors
> if in the proc comment you could write how to pass multiple args.
> E.g. an example with quotations.

Will you have a chance to merge this series?  Perhaps it was forgotten.
In that case, this is just a kindly reminder.

-Baris


  reply	other threads:[~2026-06-15  9:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 20:27 simon.marchi
2026-05-06 20:27 ` [PATCH 1/7] gdb/testsuite: remove unused arguments to gdb_breakpoint simon.marchi
2026-05-06 20:27 ` [PATCH 2/7] gdb/testsuite: make gdb_breakpoint, runto and runto_main use parse_args simon.marchi
2026-05-06 20:27 ` [PATCH 3/7] gdb/testsuite: add -inferior-args option to runto simon.marchi
2026-05-12 13:02   ` Aktemur, Baris
2026-06-19 19:29     ` Simon Marchi
2026-06-19 19:54       ` Simon Marchi
2026-05-06 20:27 ` [PATCH 4/7] gdb/testsuite: fix step-over-thread-exit.exp with native-gdbserver simon.marchi
2026-05-12 13:06   ` Aktemur, Baris
2026-06-19 19:31     ` Simon Marchi
2026-05-06 20:27 ` [PATCH 5/7] gdb/testsuite: make pie-execl.exp work " simon.marchi
2026-05-06 20:27 ` [PATCH 6/7] gdb/testsuite: use -inferior-args in gdb.base/gcore-buffer-overflow.exp simon.marchi
2026-05-06 20:27 ` [PATCH 7/7] gdb/testsuite: fix gdb.rocm/code-object-load-while-breakpoint-hit.exp with native-gdbserver simon.marchi
2026-05-12 13:18 ` [PATCH 0/7] gdb/testsuite: allow passing inferior arguments with native-gdbserver board Aktemur, Baris
2026-06-15  9:54   ` Aktemur, Baris [this message]
2026-06-19 20:09     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB6470CA89C30F591601228078F8E62@DM4PR12MB6470.namprd12.prod.outlook.com \
    --to=tankutbaris.aktemur@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox