Re: [PATCH 3/7] gdb/testsuite: add -inferior-args option to runto

[Simon Marchi <simon.marchi@polymtl.ca>]

On 6/19/26 3:29 PM, Simon Marchi wrote:
> On 5/12/26 9:02 AM, Aktemur, Baris wrote:
>> AMD General
>>
>> Hi Simon,
>>
>>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>>
>>> Add a new -inferior-args option to proc runto, to allow passing
>>> arguments to the test program.  Its value is forwarded to gdb_run_cmd,
>>> which does the right thing, including with the native-gdbserver board,
>>> where arguments need to be passed on the gdbserver command line.
>>>
>>> The option is named -inferior-args (rather than the shorter -args)
>>> because parse_args sets a variable in the caller's scope using the
>>> option name.  Naming it "-args" would clash with the "args" parameter.
>>>
>>> Subsequent patches use this new option.
>>>
>>> Change-Id: If2483c22302ed432ccd6cebef8d235e3e1d35bb8
>>> ---
>>>  gdb/testsuite/lib/gdb.exp | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>>> index 601896457fea..60bcb582aeef 100644
>>> --- a/gdb/testsuite/lib/gdb.exp
>>> +++ b/gdb/testsuite/lib/gdb.exp
>>> @@ -809,6 +809,7 @@ proc runto { linespec args } {
>>>         {no-delete-breakpoints}
>>>         {message}
>>>         {no-message}
>>> +       {inferior-args ""}
>>
>> I think this needs to be documented in the proc comment.
> 
> Ack, I will modify it like so:
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 31bb1c0fe59f..e9fd43aed846 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -817,16 +817,20 @@ proc gdb_breakpoint { linespec args } {
>  # just compare to "function" because it might be a fully qualified,
>  # single quoted C++ function specifier.
>  #
> -# If there are additional arguments, pass them to gdb_breakpoint.
> -# We recognize -no-message/-message ourselves as well as -no-delete-breakpoints.
> +# This proc recognizes the -no-message/-message, -no-delete-breakpoints
> +# and -inferior-args options.  If there are additional arguments, pass
> +# them to gdb_breakpoint.
>  #
>  # -no-message is messed up here, like gdb_breakpoint: to preserve
>  # historical usage fails are always printed by default.
>  # -no-message: turns off printing of fails (and passes, but they're already off)
>  # -message: turns on printing of passes (and fails, but they're already on)
>  #
> -# The 'no-delete-brekpoints' option stops this proc from deleting all
> +# The 'no-delete-breakpoints' option stops this proc from deleting all
>  # breakpoints.
> +#
> +# The 'inferior-args' option allows to specify arguments to pass to the
> +# inferior.

I saw later your comment in the cover letter about saying how to pass
multiple arguments.  I had to give it a try to be sure it works.

I will change the last paragraph above to read:

# The 'inferior-args' option allows to specify arguments to pass to the
# inferior.  For example, this would pass three arguments:
#
#     runto func -inferior-args "one two three"

Simon