RE: [PATCH] gdb/testsuite: fix gdb.rocm/interrupt-twice

["Aktemur, Baris" <TankutBaris.Aktemur@amd.com>]

AMD General

On Wednesday, July 1, 2026 6:19 PM, Six, Lancelot wrote:
> Since 246aecb1cd1 "gdb/testsuite: make gdb_breakpoint, runto and
> runto_main use parse_args", gdb_breakpoint arguments changed.  The
> gdb.rocm/interrupt-twice.exp testcase was not updated to call
> gdb_breakpoint with correct arguments.  This due to the new test being
> reviewed before the gdb_breakpoint landed, but it being pushed after.
>
> This patch fixes this issue.
>
> Change-Id: I0204e2c3cc9b704c79ce01386134e13b018593b8
> ---
>  gdb/testsuite/gdb.rocm/interrupt-twice.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.rocm/interrupt-twice.exp
> b/gdb/testsuite/gdb.rocm/interrupt-twice.exp
> index bdaa3babe16..0e87b5c66e8 100644
> --- a/gdb/testsuite/gdb.rocm/interrupt-twice.exp
> +++ b/gdb/testsuite/gdb.rocm/interrupt-twice.exp
> @@ -33,7 +33,7 @@ with_rocm_gpu_lock {
>       clean_restart $::testfile
>      }
>
> -    gdb_breakpoint "loop" {allow-pending} {temporary}
> +    gdb_breakpoint "loop" -allow-pending -temporary

Thank you for fixing this.  LGTM.

Reviewed-By: Tankut Baris Aktemur <TankutBaris.Aktemur@amd.com>

-Baris