Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <tankutbaris.aktemur@amd.com>, Lancelot SIX <lancelot.six@amd.com>
Subject: [PATCH] gdb/testsuite: fix gdb.rocm/interrupt-twice
Date: Wed, 1 Jul 2026 17:18:55 +0100	[thread overview]
Message-ID: <20260701161855.646399-1-lancelot.six@amd.com> (raw)

Since 246aecb1cd1 "gdb/testsuite: make gdb_breakpoint, runto and
runto_main use parse_args", gdb_breakpoint arguments changed.  The
gdb.rocm/interrupt-twice.exp testcase was not updated to call
gdb_breakpoint with correct arguments.  This due to the new test being
reviewed before the gdb_breakpoint landed, but it being pushed after.

This patch fixes this issue.

Change-Id: I0204e2c3cc9b704c79ce01386134e13b018593b8
---
 gdb/testsuite/gdb.rocm/interrupt-twice.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.rocm/interrupt-twice.exp b/gdb/testsuite/gdb.rocm/interrupt-twice.exp
index bdaa3babe16..0e87b5c66e8 100644
--- a/gdb/testsuite/gdb.rocm/interrupt-twice.exp
+++ b/gdb/testsuite/gdb.rocm/interrupt-twice.exp
@@ -33,7 +33,7 @@ with_rocm_gpu_lock {
 	clean_restart $::testfile
     }
 
-    gdb_breakpoint "loop" {allow-pending} {temporary}
+    gdb_breakpoint "loop" -allow-pending -temporary
     gdb_run_cmd
 
     set gpu_thread "undefined"

base-commit: 54e80f9747d62efea50038655801ecb58d37b507
-- 
2.43.0


             reply	other threads:[~2026-07-01 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 16:18 Lancelot SIX [this message]
2026-07-01 16:34 ` Aktemur, Baris
2026-07-03 10:58   ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701161855.646399-1-lancelot.six@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tankutbaris.aktemur@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox