RE: [PATCH v9 0/6] gdb: refine scheduler locking settings

["Gerlicher, Klaus" <klaus.gerlicher@intel.com>]

Hi,

Kindly pinging on this series.

Thanks
Klaus

> -----Original Message-----
> From: Klaus Gerlicher <klaus.gerlicher@intel.com>
> Sent: Monday, September 7, 2026 1:56 PM
> To: gdb-patches@sourceware.org
> Cc: tom@tromey.com; aburgess@redhat.com; eliz@gnu.org;
> guinevere@redhat.com
> Subject: [PATCH v9 0/6] gdb: refine scheduler locking settings
> 
> From: "Gerlicher, Klaus" <klaus.gerlicher@intel.com>
> 
> Hi Andrew, Tom, Eli,
> 
> This is version 9 of the patch series to refine scheduler locking
> settings in GDB.
> 
> For this version I took the time to get fully acquainted with the
> patch series.  In previous iterations my role had largely been limited
> to forwarding and rebasing the work; this time I reviewed all patches
> in depth, addressed Andrew's outstanding comments, and made a number
> of additional fixes and documentation improvements as listed below, hoping
> I covered every single one properly now.
> 
> Previous versions:
>   V8: https://inbox.sourceware.org/gdb-patches/20260722102746.131536-
> 1-klaus.gerlicher@intel.com/
>   V7: https://inbox.sourceware.org/gdb-patches/20260325134328.550990-
> 1-klaus.gerlicher@intel.com/
>   V6: https://inbox.sourceware.org/gdb-patches/20260204133753.547281-
> 1-klaus.gerlicher@intel.com/
>   V5: https://inbox.sourceware.org/gdb-
> patches/20260129095918.2216661-1-klaus.gerlicher@intel.com/
>   V4: https://inbox.sourceware.org/gdb-
> patches/20251205135851.2581702-1-klaus.gerlicher@intel.com/
>   V3: https://inbox.sourceware.org/gdb-patches/20250811132321.486911-
> 1-klaus.gerlicher@intel.com/
> 
> Changes since V8:
> -----------------
> 
>   * Patch 3/6:
>     - Fixed bug: V8 passed `arg` to the callback but `arg` had already
>       been advanced by option parsing.  V9 saves `org_arg` before
>       any processing and passes that instead.
>     - Added set-callback infrastructure in maint-test-settings.c so
>       that the callbacks print their received argument.
>     - Added tests in gdb.base/settings.exp and gdb.base/with.exp
>       to verify the callback receives the correct original argument.
> 
>   * Patch 5/6:
>     - Restored outer parentheses in return statement of
>       schedlock_applies_to_opts that were inadvertently removed.
> 
>   * Patch 6/6:
>     - Merged two separate comment blocks in clear_proceed_status into one.
>     - Removed default argument from schedlock_applies_to_opts; added
>       explicit nullptr with explanatory comment at the call site.
>     - Documented that 'eval' controls direct user inferior calls and
>       GDB-triggered calls (display expressions, pretty-printers), but
>       does NOT affect breakpoint/watchpoint condition evaluation, which
>       always runs on the thread that triggered the breakpoint.
>     - Updated introductory doc paragraph to list the three independently
>       controllable categories: stepping, continuing, and inferior function
>       calls.
>     - Fixed TCL test loop style: for/incr idiom per GDB testsuite
>       conventions.
>     - Fixed duplicate test name warnings in schedlock.exp.
>     - Fixed return type of some_function in schedlock.c from void to
>       int to allow use in breakpoint conditions.
>     - Removed stray blank lines in schedlock.c.
>     - Fixed "normal mode" wording in NEWS and documentation to
>       "outside replay mode" for clarity.
> 
>   * All patches:
>     - Removed non-standard "Contributed-by:" tags.
> 
> Approval status:
>   Patches 1-2/6: Approved-By: Andrew Burgess <aburgess@redhat.com>
>                  https://inbox.sourceware.org/gdb-
> patches/87zfiu6omc.fsf@redhat.com/
> 
>   Patch 1/6: Also approved by Tom Tromey <tom@tromey.com>
>              https://inbox.sourceware.org/gdb-
> patches/87a4xu9733.fsf@tromey.com/
> 
>   Patch 3/6: (Tom's approval from V8 was invalidated by the bug Andrew
> found;
>              V9 fixes the bug and needs re-review)
> 
>   Patch 4/6: (unchanged from V5, needs review)
>              https://inbox.sourceware.org/gdb-
> patches/20260129095918.2216661-5-klaus.gerlicher@intel.com/
> 
>   Patch 5/6: Reviewed-By: Eli Zaretskii <eliz@gnu.org> (documentation parts)
>              https://inbox.sourceware.org/gdb-patches/86ttb4t6kz.fsf@gnu.org/
> 
>   Patch 6/6: Reviewed-By: Eli Zaretskii <eliz@gnu.org> (documentation parts)
>              https://inbox.sourceware.org/gdb-patches/86ldx8t6ex.fsf@gnu.org/
> 
>   Overall series (V8): Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
>                        https://inbox.sourceware.org/gdb-patches/bc6fd851-29c1-436e-
> a833-a53c0cf5a18d@redhat.com/
> 
> Thanks to all reviewers for their thorough feedback.
> 
> Best regards,
> Klaus
> 
> Natalia Saiapova (6):
>   gdb: use schedlock_applies in user_visible_resume_ptid.
>   gdb, cli: remove left-over code from "set_logging_on".
>   gdb, cli: pass the argument of a set command to its callback.
>   gdb: change the internal representation of scheduler locking.
>   gdb: refine commands to control scheduler locking.
>   gdb: add eval option to lock the scheduler during infcalls.
> 
>  gdb/NEWS                                      |  30 ++
>  gdb/cli/cli-logging.c                         |   5 -
>  gdb/cli/cli-setshow.c                         |   4 +-
>  gdb/doc/gdb.texinfo                           |  89 +++-
>  gdb/infrun.c                                  | 467 +++++++++++++++---
>  gdb/maint-test-settings.c                     |  33 +-
>  gdb/testsuite/gdb.base/settings.exp           | 113 +++--
>  gdb/testsuite/gdb.base/with.exp               |   3 +-
>  .../gdb.mi/user-selected-context-sync.exp     |  29 +-
>  .../gdb.threads/hand-call-in-threads.exp      |  12 +-
>  .../multiple-successive-infcall.exp           |   7 +-
>  gdb/testsuite/gdb.threads/schedlock.c         |   3 +-
>  gdb/testsuite/gdb.threads/schedlock.exp       | 164 +++++-
>  gdb/testsuite/lib/gdb.exp                     |  77 ++-
>  14 files changed, 869 insertions(+), 167 deletions(-)
> 
> --
> 2.34.1
> 
> ________________________________________
> Intel Deutschland GmbH
> 
> Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
> 
> Tel: +49 (89) 99143-0
> 
> www.intel.de
> 
> Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran
> Sitaraman
> 
> Chairperson of the Supervisory Board: Sonja Pierer
> 
> Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB
> 186928
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.