Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Klaus Gerlicher <klaus.gerlicher@intel.com>
To: gdb-patches@sourceware.org
Cc: tom@tromey.com, aburgess@redhat.com, eliz@gnu.org, guinevere@redhat.com
Subject: [PATCH v9 2/6] gdb, cli: remove left-over code from "set_logging_on".
Date: Mon,  7 Sep 2026 11:55:33 +0000	[thread overview]
Message-ID: <20260907115537.307049-3-klaus.gerlicher@intel.com> (raw)
In-Reply-To: <20260907115537.307049-1-klaus.gerlicher@intel.com>

From: Natalia Saiapova <natalia.saiapova@intel.com>

This is a refactoring.  Remove the left-over code, which rewrites
the logging filename in "set logging on" command.

The code became unused after the deprecation of "set logging (on|off)"
command.  Before the deprecation, the command could also take a file
name and rewrite the logging file, e.g.:
  (gdb) set logging on lalala
  Copying output to lalala.
  Copying debug output to lalala.

After the command was deprecated and reimplemented as an alias to "set
logging enabled on", additional input after "on" became invalid:

  (gdb) set logging on lalala
  Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated.
  Use 'set logging enabled on'.

  "on" or "off" expected.
  (gdb) set logging on lalala
  "on" or "off" expected.
  (gdb) set logging enabled on lalala
  "on" or "off" expected.
  (gdb) set logging enabled on
  Copying output to gdb.txt.
  Copying debug output to gdb.txt.

Approved-By: Andrew Burgess <aburgess@redhat.com>
---
 gdb/cli/cli-logging.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
index c9482d59199..33bb42bb444 100644
--- a/gdb/cli/cli-logging.c
+++ b/gdb/cli/cli-logging.c
@@ -270,11 +270,6 @@ handle_redirections (int from_tty)
 static void
 set_logging_on (const char *args, int from_tty)
 {
-  const char *rest = args;
-
-  if (rest && *rest)
-    logging_filename = rest;
-
   handle_redirections (from_tty);
 }
 
-- 
2.34.1

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


  parent reply	other threads:[~2026-09-07 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 11:55 [PATCH v9 0/6] gdb: refine scheduler locking settings Klaus Gerlicher
2026-09-07 11:55 ` [PATCH v9 1/6] gdb: use schedlock_applies in user_visible_resume_ptid Klaus Gerlicher
2026-09-07 11:55 ` Klaus Gerlicher [this message]
2026-09-07 11:55 ` [PATCH v9 3/6] gdb, cli: pass the argument of a set command to its callback Klaus Gerlicher
2026-09-07 11:55 ` [PATCH v9 4/6] gdb: change the internal representation of scheduler locking Klaus Gerlicher
2026-09-07 11:55 ` [PATCH v9 5/6] gdb: refine commands to control " Klaus Gerlicher
2026-09-07 11:55 ` [PATCH v9 6/6] gdb: add eval option to lock the scheduler during infcalls Klaus Gerlicher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907115537.307049-3-klaus.gerlicher@intel.com \
    --to=klaus.gerlicher@intel.com \
    --cc=aburgess@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox