From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eixnCXWmnmqp6jMAWB0awg (envelope-from ) for ; Mon, 07 Sep 2026 07:56:37 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WeTETZKd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F2E821E167; Mon, 07 Sep 2026 07:56:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 881D31E09B for ; Mon, 07 Sep 2026 07:56:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB51A4C91759 for ; Mon, 7 Sep 2026 11:56:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB51A4C91759 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WeTETZKd Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by sourceware.org (Postfix) with ESMTPS id EB0FB4BA7987 for ; Mon, 7 Sep 2026 11:55:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB0FB4BA7987 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB0FB4BA7987 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788782150; cv=none; b=ZHYitJ1k1DZxz1oM+jeBhSl5LtwqMMOzd4xBUzbjuev2zaCzLvIwN4Cj4kbtNy++MmvrEMgS7M7HIg6gWJXjth4qMxjxTzbemRFqn5Ysv47qN07waIaufDFkrOK7H6A9HN9ldwmfJfqyd3ZlrHiaQbliFmzsqyfHDLAOgsfL7VI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788782150; c=relaxed/simple; bh=Cs4YjldV3aH/k4uSTqz57atKw/lrDuOiReXJ1fiuYKA=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=nFO5KDaKjYwTEISocbJHY6+WXA59L+710AmKvA0ExdL7N5fjtdtg5wZVaEc3F9tzeJG/A6moR9cORXC2KuqmZOYimztONx9v63328U/Govuj74kla3nlxFDiknQpOREeaTYBXMeU4pAjYvoG2ro3+o741ol1Z8kT0qpXGrvDsEg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WeTETZKd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB0FB4BA7987 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788782150; x=1820318150; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Cs4YjldV3aH/k4uSTqz57atKw/lrDuOiReXJ1fiuYKA=; b=WeTETZKdZBZzTaGkA4Kqi+wYKVTikOViKk94FwSBEyyyPwFMhgWsOq7W y1eSLsOeawDgFpAC2ROqPKUe+AKRiJyktEnvQdWakMXs3R/YBQfXGVf4o jveOD1FR2jVPBdviOvZdCJ0aCmYF/gr4phBVeeD0RSlfZctvP47qdNx+P 4ougvUbXOLWDKxoIj6/QVyTnYT5nVaYAd633GaBweqS0ptHyt/NveOhMH KdYPq+y+/5vGD2e6/s7NajHWfxC5JrDNYZU43FsIWHMaB+HRuB1HW8x06 r7gkmZ3F3ucyNHU8jdVVsoQMxCeKOsFLtKiVC/0acgF1P2IenPSL+e2HE w==; X-CSE-ConnectionGUID: JOUvhTX8SVyasZnCz2Ding== X-CSE-MsgGUID: sR6Mg8n7TKuj+BSs6ef/pQ== X-IronPort-AV: E=McAfee;i="6800,10657,11898"; a="99517497" X-IronPort-AV: E=Sophos;i="6.25,267,1779174000"; d="scan'208";a="99517497" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2026 04:55:50 -0700 X-CSE-ConnectionGUID: GOaaHx0+SL6RPpyepnZj0Q== X-CSE-MsgGUID: D3QTg3miQSGsNL6fLo7PTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,267,1779174000"; d="scan'208";a="264496075" Received: from dut1583dg2frd.igk.intel.com (HELO localhost) ([10.211.179.243]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2026 04:55:48 -0700 From: Klaus Gerlicher To: gdb-patches@sourceware.org Cc: tom@tromey.com, aburgess@redhat.com, eliz@gnu.org, guinevere@redhat.com Subject: [PATCH v9 2/6] gdb, cli: remove left-over code from "set_logging_on". Date: Mon, 7 Sep 2026 11:55:33 +0000 Message-Id: <20260907115537.307049-3-klaus.gerlicher@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260907115537.307049-1-klaus.gerlicher@intel.com> References: <20260907115537.307049-1-klaus.gerlicher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Natalia Saiapova This is a refactoring. Remove the left-over code, which rewrites the logging filename in "set logging on" command. The code became unused after the deprecation of "set logging (on|off)" command. Before the deprecation, the command could also take a file name and rewrite the logging file, e.g.: (gdb) set logging on lalala Copying output to lalala. Copying debug output to lalala. After the command was deprecated and reimplemented as an alias to "set logging enabled on", additional input after "on" became invalid: (gdb) set logging on lalala Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated. Use 'set logging enabled on'. "on" or "off" expected. (gdb) set logging on lalala "on" or "off" expected. (gdb) set logging enabled on lalala "on" or "off" expected. (gdb) set logging enabled on Copying output to gdb.txt. Copying debug output to gdb.txt. Approved-By: Andrew Burgess --- gdb/cli/cli-logging.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index c9482d59199..33bb42bb444 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -270,11 +270,6 @@ handle_redirections (int from_tty) static void set_logging_on (const char *args, int from_tty) { - const char *rest = args; - - if (rest && *rest) - logging_filename = rest; - handle_redirections (from_tty); } -- 2.34.1 ________________________________________ Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 (89) 99143-0 www.intel.de Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman Chairperson of the Supervisory Board: Sonja Pierer Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.