[commit] syms_from_objfile: Relativize also MAINLINE

[commit] syms_from_objfile: Relativize also MAINLINE

[Jan Kratochvil]

Hi,

checked-in a part of already approved patch:
	[patch 08/15] PIE: Base functionality
	http://sourceware.org/ml/gdb-patches/2009-11/msg00175.html

as it is required to have no regression of:
	Re: Regression on prelinked-sepdebug-shlibs
	http://sourceware.org/ml/gdb-patches/2010-01/msg00076.html

patch fixing a regression of:
	Re: [RFA] Make sym_read routines handle separate debug files
	http://sourceware.org/ml/gdb-patches/2009-12/msg00117.html
	http://sourceware.org/ml/gdb-cvs/2009-12/msg00042.html
	ffb64a120e667bad7b2a79c5e617bdea7328f996

No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.

I do not fully understand the reasons but the !MAINLINE conditional was there
since initial import(s) of 1999.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-01/msg00039.html

--- src/gdb/ChangeLog	2010/01/04 15:06:09	1.11198
+++ src/gdb/ChangeLog	2010/01/05 15:51:01	1.11199
@@ -1,3 +1,7 @@
+2010-01-05  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* symfile.c (syms_from_objfile): Remove the !MAINLINE conditional.
+
 2010-01-04  Ulrich Weigand  <uweigand@de.ibm.com>
 
         * features/Makefile (WHICH): Add s390-linux32, s390-linux64,
--- src/gdb/symfile.c	2010/01/01 07:31:42	1.262
+++ src/gdb/symfile.c	2010/01/05 15:51:02	1.263
@@ -799,7 +799,7 @@
 
      We no longer warn if the lowest section is not a text segment (as
      happens for the PA64 port.  */
-  if (!mainline && addrs && addrs->other[0].name)
+  if (addrs && addrs->other[0].name)
     {
       asection *lower_sect;
       asection *sect;

Re: [commit] syms_from_objfile: Relativize also MAINLINE

[Tristan Gingold]

On Jan 5, 2010, at 5:03 PM, Jan Kratochvil wrote:

> Hi,
> 
> checked-in a part of already approved patch:
> 	[patch 08/15] PIE: Base functionality
> 	http://sourceware.org/ml/gdb-patches/2009-11/msg00175.html
> 
> as it is required to have no regression of:
> 	Re: Regression on prelinked-sepdebug-shlibs
> 	http://sourceware.org/ml/gdb-patches/2010-01/msg00076.html
> 
> patch fixing a regression of:
> 	Re: [RFA] Make sym_read routines handle separate debug files
> 	http://sourceware.org/ml/gdb-patches/2009-12/msg00117.html
> 	http://sourceware.org/ml/gdb-cvs/2009-12/msg00042.html
> 	ffb64a120e667bad7b2a79c5e617bdea7328f996
> 
> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
> 
> I do not fully understand the reasons but the !MAINLINE conditional was there
> since initial import(s) of 1999.

Ah, thanks!  I will update my patch.

Tristan.