* [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
@ 2022-08-08 17:00 Nils-Christian Kempke via Gdb-patches
2022-08-08 17:00 ` [PATCH v5 1/3] gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function Nils-Christian Kempke via Gdb-patches
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Nils-Christian Kempke via Gdb-patches @ 2022-08-08 17:00 UTC (permalink / raw)
To: gdb-patches; +Cc: jinisusan.george, tom, aburgess
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v5 1/3] gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
2022-08-08 17:00 [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Nils-Christian Kempke via Gdb-patches
@ 2022-08-08 17:00 ` Nils-Christian Kempke via Gdb-patches
2022-08-23 14:40 ` [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Kempke, Nils-Christian via Gdb-patches
2023-01-09 20:26 ` [PATCH " Tom Tromey
2 siblings, 0 replies; 10+ messages in thread
From: Nils-Christian Kempke via Gdb-patches @ 2022-08-08 17:00 UTC (permalink / raw)
To: gdb-patches; +Cc: jinisusan.george, tom, aburgess
This commit is in preparation of the next commit. There, we will add
a second variation to retrieve the pc bounds for DIEs tagged with
DW_TAG_entry_point. Instead of dwarf_get_pc_bounds_ranges_or_highlow_pc
we will call a separate method for entry points. As the validity checks
at the endo f dwarf2_get_pc_bounds are the same for both variants,
we introduced the new dwarf_get_pc_bounds_ranges_or_highlow_pc method,
outsourcing part of dwarf2_get_pc_bounds.
This commit should have no functional impact on GDB.
Signed-off-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>
---
gdb/dwarf2/read.c | 71 +++++++++++++++++++++++++++++++++--------------
1 file changed, 50 insertions(+), 21 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 84faeb45238..569a7867084 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -13036,20 +13036,19 @@ dwarf2_ranges_read_low_addrs (unsigned offset, struct dwarf2_cu *cu,
});
}
-/* Get low and high pc attributes from a die. See enum pc_bounds_kind
- definition for the return value. *LOWPC and *HIGHPC are set iff
- neither PC_BOUNDS_NOT_PRESENT nor PC_BOUNDS_INVALID are returned. */
+/* Determine the low and high pc using the DW_AT_low_pc and DW_AT_high_pc or
+ DW_AT_ranges attributes of a DIE. */
-static enum pc_bounds_kind
-dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
- CORE_ADDR *highpc, struct dwarf2_cu *cu,
- addrmap *map, void *datum)
+static pc_bounds_kind
+dwarf_get_pc_bounds_ranges_or_highlow_pc (die_info *die, CORE_ADDR *low,
+ CORE_ADDR *high, dwarf2_cu *cu,
+ addrmap *map, void *datum)
{
- dwarf2_per_objfile *per_objfile = cu->per_objfile;
+ gdb_assert (low != nullptr);
+ gdb_assert (high != nullptr);
+
struct attribute *attr;
struct attribute *attr_high;
- CORE_ADDR low = 0;
- CORE_ADDR high = 0;
enum pc_bounds_kind ret;
attr_high = dwarf2_attr (die, DW_AT_high_pc, cu);
@@ -13058,17 +13057,19 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
attr = dwarf2_attr (die, DW_AT_low_pc, cu);
if (attr != nullptr)
{
- low = attr->as_address ();
- high = attr_high->as_address ();
+ *low = attr->as_address ();
+ *high = attr_high->as_address ();
if (cu->header.version >= 4 && attr_high->form_is_constant ())
- high += low;
+ *high += *low;
+
+ /* Found consecutive range of addresses. */
+ ret = PC_BOUNDS_HIGH_LOW;
}
else
- /* Found high w/o low attribute. */
- return PC_BOUNDS_INVALID;
-
- /* Found consecutive range of addresses. */
- ret = PC_BOUNDS_HIGH_LOW;
+ {
+ /* Found high w/o low attribute. */
+ ret = PC_BOUNDS_INVALID;
+ }
}
else
{
@@ -13086,16 +13087,44 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
/* Value of the DW_AT_ranges attribute is the offset in the
.debug_ranges section. */
- if (!dwarf2_ranges_read (ranges_offset, &low, &high, cu,
+ if (!dwarf2_ranges_read (ranges_offset, low, high, cu,
map, datum, die->tag))
return PC_BOUNDS_INVALID;
/* Found discontinuous range of addresses. */
ret = PC_BOUNDS_RANGES;
}
else
- return PC_BOUNDS_NOT_PRESENT;
+ {
+ /* Could not find high_pc or ranges attributed and thus no bounds
+ pair. */
+ ret = PC_BOUNDS_NOT_PRESENT;
+ }
}
+ return ret;
+}
+
+/* Get low and high pc attributes from a die. See enum pc_bounds_kind
+ definition for the return value. *LOWPC and *HIGHPC are set iff
+ neither PC_BOUNDS_NOT_PRESENT nor PC_BOUNDS_INVALID are returned. */
+
+static enum pc_bounds_kind
+dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
+ CORE_ADDR *highpc, struct dwarf2_cu *cu,
+ addrmap *map, void *datum)
+{
+ dwarf2_per_objfile *per_objfile = cu->per_objfile;
+
+ CORE_ADDR low = 0;
+ CORE_ADDR high = 0;
+ enum pc_bounds_kind ret;
+
+ ret = dwarf_get_pc_bounds_ranges_or_highlow_pc (die, &low, &high, cu, map,
+ datum);
+
+ if (ret == PC_BOUNDS_NOT_PRESENT || ret == PC_BOUNDS_INVALID)
+ return ret;
+
/* partial_die_info::read has also the strict LOW < HIGH requirement. */
if (high <= low)
return PC_BOUNDS_INVALID;
@@ -13112,7 +13141,7 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
return PC_BOUNDS_INVALID;
*lowpc = low;
- if (highpc)
+ if (highpc != nullptr)
*highpc = high;
return ret;
}
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-08-08 17:00 [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Nils-Christian Kempke via Gdb-patches
2022-08-08 17:00 ` [PATCH v5 1/3] gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function Nils-Christian Kempke via Gdb-patches
@ 2022-08-23 14:40 ` Kempke, Nils-Christian via Gdb-patches
2022-08-30 14:45 ` [PING 2][PATCH " Kempke, Nils-Christian via Gdb-patches
2023-01-09 20:26 ` [PATCH " Tom Tromey
2 siblings, 1 reply; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-08-23 14:40 UTC (permalink / raw)
To: gdb-patches; +Cc: jinisusan.george, tom
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING 2][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-08-23 14:40 ` [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Kempke, Nils-Christian via Gdb-patches
@ 2022-08-30 14:45 ` Kempke, Nils-Christian via Gdb-patches
2022-09-19 10:21 ` [PING 3][PATCH " Kempke, Nils-Christian via Gdb-patches
0 siblings, 1 reply; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-08-30 14:45 UTC (permalink / raw)
To: gdb-patches, Kempke, Nils-Christian; +Cc: jinisusan.george, tom
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Tuesday, August 23, 2022 4:40 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING 3][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-08-30 14:45 ` [PING 2][PATCH " Kempke, Nils-Christian via Gdb-patches
@ 2022-09-19 10:21 ` Kempke, Nils-Christian via Gdb-patches
2022-09-26 14:03 ` [PING 4][PATCH " Kempke, Nils-Christian via Gdb-patches
0 siblings, 1 reply; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-09-19 10:21 UTC (permalink / raw)
To: gdb-patches; +Cc: jinisusan.george, tom
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Tuesday, August 30, 2022 4:45 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 2][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Tuesday, August 23, 2022 4:40 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING 4][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-09-19 10:21 ` [PING 3][PATCH " Kempke, Nils-Christian via Gdb-patches
@ 2022-09-26 14:03 ` Kempke, Nils-Christian via Gdb-patches
2022-10-05 20:24 ` [PING 5][PATCH " Kempke, Nils-Christian via Gdb-patches
0 siblings, 1 reply; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-09-26 14:03 UTC (permalink / raw)
To: gdb-patches, Kempke, Nils-Christian; +Cc: jinisusan.george, tom
Ping!
Thanks,
NIls
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Monday, September 19, 2022 12:21 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 3][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Tuesday, August 30, 2022 4:45 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 2][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Tuesday, August 23, 2022 4:40 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING 5][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-09-26 14:03 ` [PING 4][PATCH " Kempke, Nils-Christian via Gdb-patches
@ 2022-10-05 20:24 ` Kempke, Nils-Christian via Gdb-patches
2022-10-13 8:53 ` [PING 6][PATCH " Kempke, Nils-Christian via Gdb-patches
0 siblings, 1 reply; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-10-05 20:24 UTC (permalink / raw)
To: gdb-patches; +Cc: jinisusan.george, tom
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, September 26, 2022 4:03 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 4][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
NIls
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Monday, September 19, 2022 12:21 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 3][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Tuesday, August 30, 2022 4:45 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 2][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Tuesday, August 23, 2022 4:40 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING 6][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-10-05 20:24 ` [PING 5][PATCH " Kempke, Nils-Christian via Gdb-patches
@ 2022-10-13 8:53 ` Kempke, Nils-Christian via Gdb-patches
2022-10-21 8:15 ` [PING 7][PATCH " Kempke, Nils-Christian via Gdb-patches
0 siblings, 1 reply; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-10-13 8:53 UTC (permalink / raw)
To: gdb-patches, Kempke, Nils-Christian; +Cc: jinisusan.george, tom
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Wednesday, October 5, 2022 10:24 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 5][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, September 26, 2022 4:03 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 4][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
NIls
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Monday, September 19, 2022 12:21 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 3][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Tuesday, August 30, 2022 4:45 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 2][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Tuesday, August 23, 2022 4:40 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING 7][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-10-13 8:53 ` [PING 6][PATCH " Kempke, Nils-Christian via Gdb-patches
@ 2022-10-21 8:15 ` Kempke, Nils-Christian via Gdb-patches
0 siblings, 0 replies; 10+ messages in thread
From: Kempke, Nils-Christian via Gdb-patches @ 2022-10-21 8:15 UTC (permalink / raw)
To: gdb-patches; +Cc: jinisusan.george, tom
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Thursday, October 13, 2022 10:53 AM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 6][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Wednesday, October 5, 2022 10:24 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 5][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, September 26, 2022 4:03 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 4][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
NIls
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Monday, September 19, 2022 12:21 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 3][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Tuesday, August 30, 2022 4:45 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING 2][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks,
Nils
________________________________
From: Gdb-patches <gdb-patches-bounces+nils-christian.kempke=intel.com@sourceware.org> on behalf of Kempke, Nils-Christian via Gdb-patches <gdb-patches@sourceware.org>
Sent: Tuesday, August 23, 2022 4:40 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>
Subject: Re: [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Ping!
Thanks, Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Monday, August 8, 2022 7:00 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com <aburgess@redhat.com>; jinisusan.george@amd.com <jinisusan.george@amd.com>; tom@tromey.com <tom@tromey.com>; Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
Hi,
please find attached v5 of this series. Changes since v4 incorporate
Tom's feedback here
https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
Namely, I added a special case to cooked_indexer::index_dies for
DW_TAG_entry_point entries that sets its parent correctly.
v1 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html
v2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-April/187853.html
v3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190556.html
v4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-July/190691.html
Any feedback is highly appreciated,
thanks!
Nils
Nils-Christian Kempke (3):
gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function
gdb, dwarf: add assert to dwarf2_get_pc_bounds
dwarf, fortran: add support for DW_TAG_entry_point
gdb/dwarf2/abbrev.c | 1 +
gdb/dwarf2/cooked-index.h | 3 +-
gdb/dwarf2/index-write.c | 3 +-
gdb/dwarf2/read.c | 137 +++++++++--
gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 43 ++++
gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 215 ++++++++++++++++++
gdb/testsuite/gdb.fortran/entry-point.exp | 84 +++++++
gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++
8 files changed, 529 insertions(+), 24 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point
2022-08-08 17:00 [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Nils-Christian Kempke via Gdb-patches
2022-08-08 17:00 ` [PATCH v5 1/3] gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function Nils-Christian Kempke via Gdb-patches
2022-08-23 14:40 ` [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Kempke, Nils-Christian via Gdb-patches
@ 2023-01-09 20:26 ` Tom Tromey
2 siblings, 0 replies; 10+ messages in thread
From: Tom Tromey @ 2023-01-09 20:26 UTC (permalink / raw)
To: Nils-Christian Kempke via Gdb-patches
Cc: Nils-Christian Kempke, jinisusan.george, tom, aburgess
>>>>> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:
> Hi,
> please find attached v5 of this series. Changes since v4 incorporate
> Tom's feedback here
> https://sourceware.org/pipermail/gdb-patches/2022-July/190798.html
> Namely, I added a special case to cooked_indexer::index_dies for
> DW_TAG_entry_point entries that sets its parent correctly.
Thanks. I think this is ok.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-09 20:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-08 17:00 [PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Nils-Christian Kempke via Gdb-patches
2022-08-08 17:00 ` [PATCH v5 1/3] gdb, dwarf: move part of dwarf2_get_pc_bounds into separate function Nils-Christian Kempke via Gdb-patches
2022-08-23 14:40 ` [PING][PATCH v5 0/3] Fortran entry and DW_TAG_entry_point Kempke, Nils-Christian via Gdb-patches
2022-08-30 14:45 ` [PING 2][PATCH " Kempke, Nils-Christian via Gdb-patches
2022-09-19 10:21 ` [PING 3][PATCH " Kempke, Nils-Christian via Gdb-patches
2022-09-26 14:03 ` [PING 4][PATCH " Kempke, Nils-Christian via Gdb-patches
2022-10-05 20:24 ` [PING 5][PATCH " Kempke, Nils-Christian via Gdb-patches
2022-10-13 8:53 ` [PING 6][PATCH " Kempke, Nils-Christian via Gdb-patches
2022-10-21 8:15 ` [PING 7][PATCH " Kempke, Nils-Christian via Gdb-patches
2023-01-09 20:26 ` [PATCH " Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox