Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Six, Lancelot" <Lancelot.Six@amd.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Guinevere Larsen <blarsen@redhat.com>,
	"lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PATCH] gdb/infrun: lazily load curr_frame_id in process_event_stop_test
Date: Sun, 21 Jan 2024 16:20:45 +0000	[thread overview]
Message-ID: <CH3PR12MB907977E8031DC8FD50419AA583762@CH3PR12MB9079.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240110130414.1f95f367@f39-zbm-amd>

[Public]

> I remember reviewing that change from Guinevere last year wondering if
> there might be any unexpected fallout from reading debug info earlier
> than it had been previously.  Now we know...
>
> I'm okay with your approach, but I'd like to give other maintainers
> a chance to weigh in.  So, please wait a few more days before you
> push this change.
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
> Kevin

Thanks for the review,

I am pushing this now.

Lancelot.

      reply	other threads:[~2024-01-21 16:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 19:33 Lancelot SIX
2024-01-10 20:04 ` Kevin Buettner
2024-01-21 16:20   ` Six, Lancelot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH3PR12MB907977E8031DC8FD50419AA583762@CH3PR12MB9079.namprd12.prod.outlook.com \
    --to=lancelot.six@amd.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox