From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id behVEHZErWVxBQMAWB0awg (envelope-from ) for ; Sun, 21 Jan 2024 11:21:10 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=VkdAbuwP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 30A1F1E0C3; Sun, 21 Jan 2024 11:21:10 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C4E3D1E092 for ; Sun, 21 Jan 2024 11:21:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4881E3858413 for ; Sun, 21 Jan 2024 16:21:07 +0000 (GMT) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2054.outbound.protection.outlook.com [40.107.93.54]) by sourceware.org (Postfix) with ESMTPS id C72833858D32 for ; Sun, 21 Jan 2024 16:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C72833858D32 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C72833858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.93.54 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705854050; cv=pass; b=Ry9vxJH1l1kZlG6FI7C8N9n7XHlTcDV5Lgh9Joru2EOrd0RFAODk3okqI+ZxVNSmpu2NYC/b5W5eygdGXKUjlN/jF2da0glcVqKmldYkZjy21wrRc+N2oPZfNSvJ5Q75JvWLT50Um0Q5fHx0Uw8S0hGekgHwmiD4+u8p3Ksq/V0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705854050; c=relaxed/simple; bh=KAhZy4fzMBm/ZfGNJekQVw23I66Ni/Lj5nVD7Fu9FUA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=v97Hrf1+P7aR8TszYjtznb4fZMCFe30xOeY3icjNuVnu45JHFflRr7zXP05xlRjdplDpjXiv7aBcweRY7030HLUE0p41Qc8qgQOwjaR6C0DFR5wj560xl7ot/+Dix/UmBslULBqFGEbg0Drxksh0t1bfi9RqzWeaCgZqwadTYMM= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PkognS9R1YdUNWutb3v7gCofLfCBNERJInRccjiJHsSDN0awKupZVAUuMJjocZ17W4s4OGG++xzzXoES87RI3OhddsL5yf2b+40a/PuzTp64qszqYRtCBFwogF6GRo0fT8CMlOf4w9BZ/TZORBfQsXEb70dVr2HRAUGudP0hI8eUB1JNgmfidGqE/AHorMHCvpz2x1cY1QXSfNavgXZbgRdA0Rrn3zPcM7GUI86IHm9RRDVeWgePxeLtNizHTv8GrZvMR9ji6vdGfZSvsTp6i4nEHmoGgaIVY0KBJ8zMBu2hAuaeqFmf9WsmqKdBr4FE3aR8rvIuzIgk4ZSHSIVVfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+XhFHDyIrUWv8Ix+KQJFt+bh/ptTZ+cJtCA7bzPvSI0=; b=So+COFbZG6BjFW0ZADUqF7OJAoZem9vblRyUxnyz2y68vJPX+L2XBrokT397Q/EGaQamtZSjdXrJu8UaxjAaX+j9BB3ec+Q32vsD6M9XsCtYJg2kwr0kvkRugmpM2zGwxI7/tJldIbHGPqmDFgcvbo7pxyIG9im/RaOAsKJ1Oetjy9tmZs5g+aJnZhqKgGxF7SbTqm5ZWPnk+buegbqji9zV1ShO/Hx9GMox7nzfKZftavenxLvjVzEXPWn+EiemDeSBmK6BHQtH2leCX6NUvkXP/+APMQOw/lvj3OsDhvsQ0c/d8jy15ntzyNGY6JK1GdMBSBSvbO4q9SMu9IwIrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+XhFHDyIrUWv8Ix+KQJFt+bh/ptTZ+cJtCA7bzPvSI0=; b=VkdAbuwPq228IAkWQ4RXTCzK3l8LNdzHAlS3GYBYdBh3U06qHADonz8pyvC/GxQPpgD+OZL3onEQDgcjaW7CLKT3fWPsNlPU8FhWoePbbjk5mzVZNfV8PPsNrtDwCJP7Mw5FP16bgc7WZZMYG4kf5LseVJHQMfN643kGhIaAXxo= Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by BL0PR12MB4916.namprd12.prod.outlook.com (2603:10b6:208:1ce::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.31; Sun, 21 Jan 2024 16:20:46 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::aa88:12a0:aee9:bf53]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::aa88:12a0:aee9:bf53%3]) with mapi id 15.20.7202.031; Sun, 21 Jan 2024 16:20:45 +0000 From: "Six, Lancelot" To: Kevin Buettner CC: "gdb-patches@sourceware.org" , Guinevere Larsen , "lsix@lancelotsix.com" Subject: RE: [PATCH] gdb/infrun: lazily load curr_frame_id in process_event_stop_test Thread-Topic: [PATCH] gdb/infrun: lazily load curr_frame_id in process_event_stop_test Thread-Index: AQHaOcTfE1lJQCyDpEyNKxzJ+P0bE7DTjNQAgBEKxFA= Date: Sun, 21 Jan 2024 16:20:45 +0000 Message-ID: References: <20231228193359.3888031-1-lancelot.six@amd.com> <20240110130414.1f95f367@f39-zbm-amd> In-Reply-To: <20240110130414.1f95f367@f39-zbm-amd> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=8bea5553-b27c-4b4b-9771-1bdbb1a9cdd2; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2024-01-21T16:19:23Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB9079:EE_|BL0PR12MB4916:EE_ x-ms-office365-filtering-correlation-id: 20f78a79-c610-46f6-3993-08dc1a9cec02 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KiEI3mE8nTl1i2ZdO1xdSA5uix6rSN1ZmSiRoyl9XJbU7JKQJJjVlpoV6ok3Z8Uqxyf9/UMHEh1F0CZkaplNErmSNM16tiw1VFwqb0jnm/PtjTXAVTRkCP6P8HHVjW/wVySCSLucMMulTxr7b7Qc17LJd7Y9oMXRgG1inxow4lW2NERLHXHCHEJU1mClUuyfOygGXOL9M5mE5uG089lQ6fuKufCdwsdlvepyiPgWYL25YoNYC0g+seXccxstb10c0AtndI9PCErCMysInSZBT4lj+T19rBuIvr+webJqENiIobAsTI2E0rnqUT/o2vfc/mdeHwKe8tYs50MRuLfWEQ8mFdpSWzO0bY3kvfyMQ1HsEYAZ0FPWYu4KZNgLS/hshdlQhU6nnhO2M5OWgoD+yr0oUBCtk+kF710VWL1Z/Fywlhk6cSuEL2ZTpLPv9KWPHRfmvf1tV+ZuUbsME1Cy1x0eDF4SfXD0MMmewgbGV5uRGx4tztdem+eDdpiT4yPZHKUOuxxnMb48kvO8xzQaAuVBrH9T0cWVrJ5Qmkd6HqTKOGmK3jF3XVVL2wLtLSIVnw8QcFjqUpioOMAl3YF/fqVal4OxE5mVafBbJs7wjzSnexo41J4scF4vuYK/BkA7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(136003)(39850400004)(346002)(366004)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(41300700001)(26005)(55016003)(38070700009)(7696005)(478600001)(9686003)(6506007)(71200400001)(38100700002)(122000001)(4744005)(5660300002)(66476007)(76116006)(54906003)(64756008)(66556008)(66946007)(66446008)(316002)(86362001)(2906002)(33656002)(8936002)(4326008)(8676002)(6916009)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DDwU/PgS9syfuhPWlSIqVqE7GDktXAvKUy1P8kcAecSmwEfpJnyC6A9jE9pG?= =?us-ascii?Q?tnjRLERlFAeV0yX77+B9WQq5bnHgpWCy1uBpCNecdf4MzEr8xVhoxVqLDOC4?= =?us-ascii?Q?KnTarknCa/PoIzRncNcN7KRSgGNtiTy0qdMr2aYr2TzshzBXSfp9X3TGmpLg?= =?us-ascii?Q?Yq2u3SipLZ1NNk6RoLxztuKlt2k0T6l2ZgmU5o3BxrGqGdLtyS7QPyehsGwR?= =?us-ascii?Q?Vdq8Cp96AHaWrQKPk4S5ExsInHQ+JWylBU4z9KsCtbf3Gca8Q9jH+pjTYGjF?= =?us-ascii?Q?iyUTnQQZaSyZzseTfzcgbVl3Zq0yjUdFaZY9ymA5/qpLYKqFlHnr2CR4nfkJ?= =?us-ascii?Q?3pbIyogSZIF0Q54vAbVuuOnpjk58rt+bloYS4WFFFyesvCamwB9fIJkl6m+S?= =?us-ascii?Q?nQX82j6O2wtjWEJjClNqhVsXaGlYB766OZ8+Yi20/8DuWcT/JOMcARyHSLQ3?= =?us-ascii?Q?Y8EH3Yer3GoAPaB/xTJvbwlau6lug1lQSDt8D+53n7Cv7p1lfh0hsuMvTbbV?= =?us-ascii?Q?ndVkFz+zPLMFuiC4iV22h73/dUlkD7hZ0h81oeMCSKWi+cTxVJCpr5wq5CMw?= =?us-ascii?Q?+ciTNIH4GTkfPadfrgz3rfKSmJ0Wq/rns7MzGf+3ynAC4Lm/jk7PeSpVu/co?= =?us-ascii?Q?9MfNCtWrEkaaSRNDqAQLyyPdX9rIDwN/4D+Jw0L4saA3K4D4d/8VxzGMZR4q?= =?us-ascii?Q?0WZd5XHrkSld4FJDTpTxhVOqX87yv+lNFcmQ/lH/ADwfppwP4d+lfzSM8dGL?= =?us-ascii?Q?CcbBRafxLxgAtivS6W6zGONzPWt8Uhc+IYI3nJLwNtOnPZJPwksf32oGgb94?= =?us-ascii?Q?AxJjsNVq2s6daRTBTlpuw7+IjcgRzX8Lx6E69VZHIJFm5ZSn2DZHlUgLEjx9?= =?us-ascii?Q?jZllUIfx1+bAv122870nbl3Xxv3YoktBlytIA8Bh5WxkIFLvvljEcuMjwzP0?= =?us-ascii?Q?I5up8V9tH9aOZgjMYCRXLqRw812zhAM7QUs0E05hB2M3VJGayPwSJaT3HdO2?= =?us-ascii?Q?TKcfhmIkY0LRk71emEN/gHnIHIrhRRKy76KO4reyvD7D+/VyOZoe5tW8G5pL?= =?us-ascii?Q?Tsm4g9M8I5eTbKSS3Jvjqb6iQNJlVsYP3clfAmhqqETvfD/8MBEvsjd1woHV?= =?us-ascii?Q?XViEYe5IeoRqzpPcJmSE+nJs4iVT2zuAixU4spCXoJG72MyK39+E+wQNA6Ym?= =?us-ascii?Q?rOeOwaA2oiWhdfYH6F7ly7yBZfY7oQDSsTttpe6V3SMpsvzSxg5CVtWVr+BE?= =?us-ascii?Q?IBqERB2qlG6z91XExnK1XazZMkatE59XLaQ1YmRwWyy1xA2UERCPMk8c0rtM?= =?us-ascii?Q?SxH0HM8vsTFo2iKUM7yFrKuBwYahgWGFbu6N9tMP6fgmkJQ66CxWSXZXUP/A?= =?us-ascii?Q?Crrl5lFQXkz/CF3/FJd8ZMbU4OUCOBgMaY02yHRYCDcNrKxULeYCqW12TJYO?= =?us-ascii?Q?vWQ2jcxHFMKdtUDgE49ReDWNIbOmmvT81aXz+MKXoSBYQraTqxNyOwXoEvEu?= =?us-ascii?Q?90gk0g1vraJTrSmN8SQcRD0ce6ORJE+BEP38zEnNS/K5gO9ckyEsZdMpIw6c?= =?us-ascii?Q?rJ0CW1ORjazU5f0MEIg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20f78a79-c610-46f6-3993-08dc1a9cec02 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2024 16:20:45.5949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SXqdzoANM0Vjw4UdzInnGdAWBt9KUUcDVbyaCJGVh7Xijdg6FHF3Baj6vI5jmyNtPrO8XlBP0AdBYdBEK7XhKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4916 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org [Public] > I remember reviewing that change from Guinevere last year wondering if > there might be any unexpected fallout from reading debug info earlier > than it had been previously. Now we know... > > I'm okay with your approach, but I'd like to give other maintainers > a chance to weigh in. So, please wait a few more days before you > push this change. > > Approved-by: Kevin Buettner > > Kevin Thanks for the review, I am pushing this now. Lancelot.