Re: [PATCH 1/5] Code for nds32 target

[Wei-cheng Wang <cole945@gmail.com>]

On Wed, Jul 10, 2013 at 1:37 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 07/08/2013 05:27 PM, Wei-cheng Wang wrote:
> Here is the 2nd half.
>> +  struct cleanup *back_to;
>> +
>> +  /* Reload symtab if abfd changed.
> I am sorry that I can't get the points of doing this.  Can you elaborate
> please?

  I've revised the comment as such.

  /* When disassembling ex9 instructions, they are annotated with
     the original instructions at the end of line.  For example,

        0x00500122 <+82>:    ex9.it #4          ! movi $r13, 10

     Dissembler needs the symbol table to extract the original instruction
     in _ITB_BASE_ table.  If the object file is changed, reload symbol
     table.  */

>> +
>> +/* Callback for "nds32 dump" command.
>> +
>> +   Dump current register and stack for debug gdb.  */
>> +
> Do we really need this command?  You can examine registers via command 'info
> registers', and examine stack as a piece of memory via command 'x'.

  This was used to dump registers and stack and create a gdbinit script,
  so I can use the script to debug backtrace porting issues.
  Anyway, I've removed this command in revised patch.  I think I don't need
  it anymore.

> The last but not least, the binutils patch hasn't go in yet, so it is pity
> that I can't build GDB with you patches for nds32 target.
  It still needs more work :p
> You also need a news entry in gdb/NEWS about this new port.  Open gdb/NEWS,
> and then you will know how to add one entry for nds32 port :)
  Just add our target and send a separate patch for it?

Wei-cheng