From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5432 invoked by alias); 11 Jul 2013 14:26:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5422 invoked by uid 89); 11 Jul 2013 14:26:29 -0000 X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Jul 2013 14:26:28 +0000 Received: by mail-lb0-f175.google.com with SMTP id r10so6629243lbi.6 for ; Thu, 11 Jul 2013 07:26:26 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.20.165 with SMTP id o5mr17323635lae.71.1373552786235; Thu, 11 Jul 2013 07:26:26 -0700 (PDT) Received: by 10.112.71.139 with HTTP; Thu, 11 Jul 2013 07:26:26 -0700 (PDT) In-Reply-To: <51DCF32E.9020303@codesourcery.com> References: <51DCF32E.9020303@codesourcery.com> Date: Thu, 11 Jul 2013 14:26:00 -0000 Message-ID: Subject: Re: [PATCH 1/5] Code for nds32 target From: Wei-cheng Wang To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2013-07/txt/msg00315.txt.bz2 On Wed, Jul 10, 2013 at 1:37 PM, Yao Qi wrote: > On 07/08/2013 05:27 PM, Wei-cheng Wang wrote: > Here is the 2nd half. >> + struct cleanup *back_to; >> + >> + /* Reload symtab if abfd changed. > I am sorry that I can't get the points of doing this. Can you elaborate > please? I've revised the comment as such. /* When disassembling ex9 instructions, they are annotated with the original instructions at the end of line. For example, 0x00500122 <+82>: ex9.it #4 ! movi $r13, 10 Dissembler needs the symbol table to extract the original instruction in _ITB_BASE_ table. If the object file is changed, reload symbol table. */ >> + >> +/* Callback for "nds32 dump" command. >> + >> + Dump current register and stack for debug gdb. */ >> + > Do we really need this command? You can examine registers via command 'info > registers', and examine stack as a piece of memory via command 'x'. This was used to dump registers and stack and create a gdbinit script, so I can use the script to debug backtrace porting issues. Anyway, I've removed this command in revised patch. I think I don't need it anymore. > The last but not least, the binutils patch hasn't go in yet, so it is pity > that I can't build GDB with you patches for nds32 target. It still needs more work :p > You also need a news entry in gdb/NEWS about this new port. Open gdb/NEWS, > and then you will know how to add one entry for nds32 port :) Just add our target and send a separate patch for it? Wei-cheng