From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make BLOCK_START and BLOCK_END into rvalues
Date: Sat, 16 May 2020 11:36:32 -0500 [thread overview]
Message-ID: <CAPTJ0XFx6Ay=aErWy4Xtza+vH4oBimC4E19iEngtP42=nTAnhA@mail.gmail.com> (raw)
In-Reply-To: <20200516151021.7080-1-tom@tromey.com>
On Sat, May 16, 2020, 10:10 Tom Tromey <tom@tromey.com> wrote:
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index b9bcc33080a..b13857b0dda 100644
> --- a/gdb/buildsym.c
> +++ b/gdb/buildsym.c
> @@ -242,8 +242,8 @@ buildsym_compunit::finish_block_internal
> }
> }
>
> - BLOCK_START (block) = start;
> - BLOCK_END (block) = end;
> + block->startaddr = start = start;
>
I think you only need one "start" here :)
>
>
prev parent reply other threads:[~2020-05-16 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 15:10 Tom Tromey
2020-05-16 16:15 ` Simon Marchi
2020-05-17 14:05 ` Tom Tromey
2020-05-17 14:40 ` Simon Marchi
2020-05-16 16:36 ` Christian Biesinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XFx6Ay=aErWy4Xtza+vH4oBimC4E19iEngtP42=nTAnhA@mail.gmail.com' \
--to=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox