From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com
 [IPv6:2607:f8b0:4864:20::842])
 by sourceware.org (Postfix) with ESMTPS id A64963840C2D
 for <gdb-patches@sourceware.org>; Sat, 16 May 2020 16:36:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A64963840C2D
Received: by mail-qt1-x842.google.com with SMTP id v4so4680969qte.3
 for <gdb-patches@sourceware.org>; Sat, 16 May 2020 09:36:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Fow+mQUVwTYH9zp6Qcmac9/bAykHk/Oautjtm3T9J8w=;
 b=TC4l3tudpbxwNVhWtpVEcbSNA/M0Z5amECSIU6G3MdTq0d3+7PgHoU5Tjv3mJAo3xS
 5BTDp1cHYxqCIpXDwKH3ITH0OXrWRhzkkSWEVpYC4zS3gA2qQn1i5FcNxrrOP6pB1/9q
 o/7fiQxVdlB2tJIiVXEL+zbiUVso4k0gnXtd4T4Okl41A0RNMlymnKmyum7MeMbR/e9V
 9T91ykhRgDYlRlC+CZd21FYPcfjkqqRbc+c3SN32U7rST5cwCgE1AwDn95/PF0yfKONh
 bGALmmpsV9jr2U1OJPbCfTwExQajrhYku1MxLNLzKrzCavoejhcuezm1pujCpyv86juB
 +m3g==
X-Gm-Message-State: AOAM531AjlZHpH5fpl4l5klDUp7W7JFxRJl7Fs+jfJLWLgl44lmcL0de
 CW5Xmo0HaOB+nZUu9m3Z/g7R4eJp/TVzEGf+sSfXNxlU
X-Google-Smtp-Source: ABdhPJyFq0TldRzD1aGOA3pXZ1YO+2gsac+6E8grZ42Yxh0Xl2gfX2H4gVTHp1RMA2xiVhjK7ekge9Uv88jXdEDK2yE=
X-Received: by 2002:ac8:434e:: with SMTP id a14mr7143073qtn.161.1589647003910; 
 Sat, 16 May 2020 09:36:43 -0700 (PDT)
MIME-Version: 1.0
References: <20200516151021.7080-1-tom@tromey.com>
In-Reply-To: <20200516151021.7080-1-tom@tromey.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Sat, 16 May 2020 11:36:32 -0500
Message-ID: <CAPTJ0XFx6Ay=aErWy4Xtza+vH4oBimC4E19iEngtP42=nTAnhA@mail.gmail.com>
Subject: Re: [PATCH] Make BLOCK_START and BLOCK_END into rvalues
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
X-Spam-Status: No, score=-25.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 16 May 2020 16:36:45 -0000

On Sat, May 16, 2020, 10:10 Tom Tromey <tom@tromey.com> wrote:

> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index b9bcc33080a..b13857b0dda 100644
> --- a/gdb/buildsym.c
> +++ b/gdb/buildsym.c
> @@ -242,8 +242,8 @@ buildsym_compunit::finish_block_internal
>         }
>      }
>
> -  BLOCK_START (block) = start;
> -  BLOCK_END (block) = end;
> +  block->startaddr = start = start;
>

I think you only need one "start" here :)

>
>