Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [pushed] Remove some obsolete comments
Date: Sat, 7 Mar 2020 09:09:20 -0600	[thread overview]
Message-ID: <CAPTJ0XFCUce_9d1g4s_1GDfMfCH9HsYJ5MRVZRYh=_=VsOVmqw@mail.gmail.com> (raw)
In-Reply-To: <20200307150322.22813-1-tom@tromey.com>

On Sat, Mar 7, 2020 at 9:03 AM Tom Tromey <tom@tromey.com> wrote:
>
> While working on complex number support, I found a couple of
> apparently obsolete coments.  This removes them.
>
> 2020-03-07  Tom Tromey  <tom@tromey.com>
>
>         * valops.c (value_literal_complex): Remove obsolete comment.
>         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
>         comment.
> ---
>  gdb/ChangeLog  | 6 ++++++
>  gdb/gdbtypes.h | 4 +---
>  gdb/valops.c   | 4 +---
>  3 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
> index 74498435822..cb674dbc1e8 100644
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -120,9 +120,7 @@ enum type_code
>      TYPE_CODE_FUNC,            /**< Function type */
>      TYPE_CODE_INT,             /**< Integer type */
>
> -    /* * Floating type.  This is *NOT* a complex type.  Beware, there
> -       are parts of GDB which bogusly assume that TYPE_CODE_FLT can
> -       mean complex.  */
> +    /* * Floating type.  This is *NOT* a complex type.  */
>      TYPE_CODE_FLT,
>
>      /* * Void type.  The length field specifies the length (probably
> diff --git a/gdb/valops.c b/gdb/valops.c
> index 7fc555a8108..d48474665c3 100644
> --- a/gdb/valops.c
> +++ b/gdb/valops.c
> @@ -3856,9 +3856,7 @@ value_slice (struct value *array, int lowbound, int length)
>
>  /* Create a value for a FORTRAN complex number.  Currently most of the
>     time values are coerced to COMPLEX*16 (i.e. a complex number
> -   composed of 2 doubles.  This really should be a smarter routine
> -   that figures out precision intelligently as opposed to assuming
> -   doubles.  FIXME: fmb  */
> +   composed of 2 doubles.  */

Is this missing a closing parenthesis?

>
>  struct value *
>  value_literal_complex (struct value *arg1,
> --
> 2.17.2
>


  reply	other threads:[~2020-03-07 15:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07 15:03 Tom Tromey
2020-03-07 15:09 ` Christian Biesinger [this message]
2020-03-08 17:42   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPTJ0XFCUce_9d1g4s_1GDfMfCH9HsYJ5MRVZRYh=_=VsOVmqw@mail.gmail.com' \
    --to=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox