From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by server2.sourceware.org (Postfix) with ESMTPS id 9D7993937C28 for ; Sat, 7 Mar 2020 15:10:02 +0000 (GMT) Received: by mail-ot1-x32a.google.com with SMTP id i14so5418514otp.5 for ; Sat, 07 Mar 2020 07:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/T8X5MCxppu1ANxBD1zxTvy4hxn0g+1kKJXE9O+ydKw=; b=uNDLEl9AUkg7awn6M+NcXUq2GYOg6u40I3IxtQRQv0tuZJ6eW32che7gnEdtaEo04M EBlaNCif86fpM80tXrAL3/FxWNR9pI/BF0Npb2CpmRQ28R2IXKF8ubG9GdkJvRXc6buc 0q9hlORndLC6hrKMUO1SB+EkHQmNA8IPm+TuwgVBralxlXfaYmkotMi9yoan3y6h9HA3 OCnFl4GREDTyFiPoHXpZv5l1+YA+/MSSiDD4XO9KkO+L6eXZW+rqqJyr+1d+LBv7gEXa 51LkR1M9uFmCUu98ijoRa4Fdzk9eWgjNMN6MJUYJqw+UOELkEz5TaFTfyftLWI9th+E/ APoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/T8X5MCxppu1ANxBD1zxTvy4hxn0g+1kKJXE9O+ydKw=; b=kd5pfmuiykM73W4f7bT/mute0jmSSzFJgo5MugaSI0Q9biqvZEaQgQOLvKgynIsoVP NfgDsycImZX+aEprkrOHNLnN+mdgvAtr/Icpc4iVoZE8HhMLHpHcazYCjjxkDEXDUCvi oIVtvhC7RGHQsKkGBUXciiszulsrk9+aoQ3qRtDYy89vqmowgphXwgTqWGPMSUu3CQ9n eYd3dDv4oK8QUEpHWdukuSLLr9qjyvkrqvuN2RQfB7/00+pAa91DMwaLXG3OZM/h1ubx Ng0l4WsbOoKgzTTdMuk8BsLxptM4AJ7hgh/o1f5n6ju7uNjBTZumvJ34biyjNdlaatRc K/Qw== X-Gm-Message-State: ANhLgQ2zhA3fa5AdIiTshHwvVFLTv8jdaKGTu17Mpw3jciBZwuJfAYVB 4iogCQhDKmgVAyb+hSfYLmrfeO6lHfclhY3Ya+pC6J0+ X-Google-Smtp-Source: ADFU+vuLDAlO+OQmGxNyOzNhJx1o8QDntW0w7VRSP49peOX5AolPNy2tgEPazKSzSLgBrKYO92pn6/7mpGXecpTsvT0= X-Received: by 2002:a9d:1a4:: with SMTP id e33mr1465823ote.343.1583593800457; Sat, 07 Mar 2020 07:10:00 -0800 (PST) MIME-Version: 1.0 References: <20200307150322.22813-1-tom@tromey.com> In-Reply-To: <20200307150322.22813-1-tom@tromey.com> From: Christian Biesinger Date: Sat, 7 Mar 2020 09:09:20 -0600 Message-ID: Subject: Re: [pushed] Remove some obsolete comments To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2020 15:10:03 -0000 On Sat, Mar 7, 2020 at 9:03 AM Tom Tromey wrote: > > While working on complex number support, I found a couple of > apparently obsolete coments. This removes them. > > 2020-03-07 Tom Tromey > > * valops.c (value_literal_complex): Remove obsolete comment. > * gdbtypes.h (enum type_code) : Remove obsolete > comment. > --- > gdb/ChangeLog | 6 ++++++ > gdb/gdbtypes.h | 4 +--- > gdb/valops.c | 4 +--- > 3 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index 74498435822..cb674dbc1e8 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -120,9 +120,7 @@ enum type_code > TYPE_CODE_FUNC, /**< Function type */ > TYPE_CODE_INT, /**< Integer type */ > > - /* * Floating type. This is *NOT* a complex type. Beware, there > - are parts of GDB which bogusly assume that TYPE_CODE_FLT can > - mean complex. */ > + /* * Floating type. This is *NOT* a complex type. */ > TYPE_CODE_FLT, > > /* * Void type. The length field specifies the length (probably > diff --git a/gdb/valops.c b/gdb/valops.c > index 7fc555a8108..d48474665c3 100644 > --- a/gdb/valops.c > +++ b/gdb/valops.c > @@ -3856,9 +3856,7 @@ value_slice (struct value *array, int lowbound, int length) > > /* Create a value for a FORTRAN complex number. Currently most of the > time values are coerced to COMPLEX*16 (i.e. a complex number > - composed of 2 doubles. This really should be a smarter routine > - that figures out precision intelligently as opposed to assuming > - doubles. FIXME: fmb */ > + composed of 2 doubles. */ Is this missing a closing parenthesis? > > struct value * > value_literal_complex (struct value *arg1, > -- > 2.17.2 >