Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PUSHED/OBVIOUS] Don't duplicate comment in symfile.c and .h
Date: Fri, 20 Sep 2019 02:59:00 -0000	[thread overview]
Message-ID: <CAPTJ0XF98P-AoSQ4Cdp6G6AGors8d2WjRQXTGNv-EVUVc4HU_g@mail.gmail.com> (raw)
In-Reply-To: <20190920025733.42046-1-cbiesinger@google.com>

argh, accidentally sent the wrong file. please disregard (this is a duplicate)

On Fri, Sep 20, 2019 at 11:57 AM Christian Biesinger
<cbiesinger@google.com> wrote:
>
> This just replaces the comment in the .c file with
> "See symfile.h.".
>
> gdb/ChangeLog:
>
> 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
>
>         * symfile.c (auto_solib_add): Replace comment with a reference
>         to the header file.
> ---
>  gdb/symfile.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/gdb/symfile.c b/gdb/symfile.c
> index 3cd514409b..259a30aa04 100644
> --- a/gdb/symfile.c
> +++ b/gdb/symfile.c
> @@ -141,15 +141,7 @@ static const char *print_symbol_loading_enums[] =
>  };
>  static const char *print_symbol_loading = print_symbol_loading_full;
>
> -/* If non-zero, shared library symbols will be added automatically
> -   when the inferior is created, new libraries are loaded, or when
> -   attaching to the inferior.  This is almost always what users will
> -   want to have happen; but for very large programs, the startup time
> -   will be excessive, and so if this is a problem, the user can clear
> -   this flag and then add the shared library symbols as needed.  Note
> -   that there is a potential for confusion, since if the shared
> -   library symbols are not loaded, commands like "info fun" will *not*
> -   report all the functions that are actually present.  */
> +/* See symfile.h.  */
>
>  int auto_solib_add = 1;
>
> --
> 2.23.0.237.gc6a4ce50a0-goog
>


  reply	other threads:[~2019-09-20  2:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 20:30 [PATCH v2] Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order Christian Biesinger via gdb-patches
2019-08-27 21:38 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-08-27 23:03   ` Christian Biesinger via gdb-patches
2019-09-10 14:35     ` [ping] " Christian Biesinger via gdb-patches
2019-09-17 12:03       ` Christian Biesinger via gdb-patches
2019-09-20  1:01     ` Simon Marchi
2019-09-20  2:57       ` Christian Biesinger via gdb-patches
2019-09-20  2:57         ` [PUSHED/OBVIOUS] Don't duplicate comment in symfile.c and .h Christian Biesinger via gdb-patches
2019-09-20  2:59           ` Christian Biesinger via gdb-patches [this message]
2019-09-20  2:58         ` [PATCH v4] Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order Christian Biesinger via gdb-patches
2019-09-20 10:56           ` Simon Marchi
2019-09-21  2:20             ` Christian Biesinger via gdb-patches
2019-09-17  3:10 [PUSHED/OBVIOUS] Don't duplicate comment in symfile.c and .h Christian Biesinger via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPTJ0XF98P-AoSQ4Cdp6G6AGors8d2WjRQXTGNv-EVUVc4HU_g@mail.gmail.com \
    --to=gdb-patches@sourceware.org \
    --cc=cbiesinger@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox