Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order
Date: Fri, 20 Sep 2019 10:56:00 -0000	[thread overview]
Message-ID: <744d88b3-c2af-0a98-c1ff-07ac898d7c5c@simark.ca> (raw)
In-Reply-To: <20190920025847.43084-1-cbiesinger@google.com>

On 2019-09-19 10:58 p.m., Christian Biesinger via gdb-patches wrote:
> All implementations of either function use it for the same purpose (except
> Darwin, which is a no-op): to prefer a symbol in the current objfile over
> symbols with the same name in other objfiles. There does not seem to be a
> reason to have both mechanisms for that purpose.

Hi Christian,

This LGTM, it is fine to push after the SPU removal patch.

Thanks,

Simon


  reply	other threads:[~2019-09-20 10:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 20:30 [PATCH v2] " Christian Biesinger via gdb-patches
2019-08-27 21:38 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-08-27 23:03   ` Christian Biesinger via gdb-patches
2019-09-10 14:35     ` [ping] " Christian Biesinger via gdb-patches
2019-09-17 12:03       ` Christian Biesinger via gdb-patches
2019-09-20  1:01     ` Simon Marchi
2019-09-20  2:57       ` Christian Biesinger via gdb-patches
2019-09-20  2:57         ` [PUSHED/OBVIOUS] Don't duplicate comment in symfile.c and .h Christian Biesinger via gdb-patches
2019-09-20  2:59           ` Christian Biesinger via gdb-patches
2019-09-20  2:58         ` [PATCH v4] Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order Christian Biesinger via gdb-patches
2019-09-20 10:56           ` Simon Marchi [this message]
2019-09-21  2:20             ` Christian Biesinger via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=744d88b3-c2af-0a98-c1ff-07ac898d7c5c@simark.ca \
    --to=simark@simark.ca \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox