From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.
Date: Mon, 07 Oct 2019 22:27:00 -0000 [thread overview]
Message-ID: <CAPTJ0XE4pNfJHdYF4gmp82NcvaRNL6KoozWW0r9sntTR6Pw0Ow@mail.gmail.com> (raw)
In-Reply-To: <878spwqjv1.fsf@tromey.com>
On Mon, Oct 7, 2019 at 5:19 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> gdb/ChangeLog:
> Christian> 2019-10-07 Christian Biesinger <cbiesinger@google.com>
>
> Christian> * language.c (lang_frame_mismatch_warn): Make const and move
> Christian> comment...
> Christian> * language.h (lang_frame_mismatch_warn): ... here. Also add
> Christian> declaration.
> Christian> * top.c (lang_frame_mismatch_warn): Remove declaration.
>
> Thanks.
>
> Maybe it would be better to just have a function to print this message.
> That would make it easier to gettext-ize.
>
> It can be done as-is though by changing it to a const char *, then
> wrapping the literal in N_(...), and changing the uses to _(...).
Thanks. It seems to work for me even without changing to const char*,
so I'll send a patch momentarily which does that.
Christian
next prev parent reply other threads:[~2019-10-07 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:57 Christian Biesinger via gdb-patches
2019-10-07 22:20 ` Tom Tromey
2019-10-07 22:27 ` Christian Biesinger via gdb-patches [this message]
2019-10-07 22:28 ` Christian Biesinger via gdb-patches
2019-10-08 12:46 ` Tom Tromey
2019-10-08 15:16 ` Christian Biesinger via gdb-patches
2019-10-08 12:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XE4pNfJHdYF4gmp82NcvaRNL6KoozWW0r9sntTR6Pw0Ow@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox