From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105155 invoked by alias); 7 Oct 2019 22:27:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105147 invoked by uid 89); 7 Oct 2019 22:27:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.0 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy= X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Oct 2019 22:27:28 +0000 Received: by mail-ot1-f67.google.com with SMTP id c10so12422960otd.9 for ; Mon, 07 Oct 2019 15:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8B/SVtlLMlLHKts3oDhMVIlxl6RZ8YC09VFT8U1d5NY=; b=B0tLFfgNHg5bnZ4XFlqwNi5xQXFyVm8k8KD8lyR06XVoIz8fIY6gqlenXHZw3deA17 DPALHZcUPuyDmL1AS3HczoPeMiQMMByM88+jz/DE1RCFJTWgg2hV/xosd4DIGkYHHYNg WIaQDq+fCX6EC2gzCHb430BZDSzvkCP5odB+myquu/IHs2SZ4l+IT90E+4F9FgVBzP9C jp7iglrsI44GG4ZkL/OsKY7KkrhASqcC5/czY4H8pQVVScsr5FDL45SRGVQeevxz4ndn HaBvSyCRmtzGCT3nF5mmpxbSVBPOsg1aJjj6sWLuVjMcoWzY6+hOtKQH4V3Mb8CrZD6X Rdtg== MIME-Version: 1.0 References: <20191007175734.257671-1-cbiesinger@google.com> <878spwqjv1.fsf@tromey.com> In-Reply-To: <878spwqjv1.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Mon, 07 Oct 2019 22:27:00 -0000 Message-ID: Subject: Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header. To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00209.txt.bz2 On Mon, Oct 7, 2019 at 5:19 PM Tom Tromey wrote: > > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > Christian> gdb/ChangeLog: > Christian> 2019-10-07 Christian Biesinger > > Christian> * language.c (lang_frame_mismatch_warn): Make const and move > Christian> comment... > Christian> * language.h (lang_frame_mismatch_warn): ... here. Also add > Christian> declaration. > Christian> * top.c (lang_frame_mismatch_warn): Remove declaration. > > Thanks. > > Maybe it would be better to just have a function to print this message. > That would make it easier to gettext-ize. > > It can be done as-is though by changing it to a const char *, then > wrapping the literal in N_(...), and changing the uses to _(...). Thanks. It seems to work for me even without changing to const char*, so I'll send a patch momentarily which does that. Christian