Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
		"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: RFC: "set" command with 2 arguments instead of one?
Date: Mon, 24 Nov 2014 15:36:00 -0000	[thread overview]
Message-ID: <CAP9bCMTSTGAippgSkeY00j75Tnarw1qq6S0Q=s7ns1drpYGNOA@mail.gmail.com> (raw)
In-Reply-To: <20141124071258.GI5774@adacore.com>

On Sun, Nov 23, 2014 at 11:12 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> This feels like a case where we need to at least think about some
>> future-proofing.
>> One way some commands separate expressions is with commas.
>> I'm not fond of optional commas (setting aside the thread on
>> info macro -at LOCATION,).
>> IOW, if it turns out that we want to use commas down the road
>> to separate expressions here, then I'd prefer the commas
>> be required today.
>> E.g., set mpx bound ADDR, LBOUND, UBOUND
>
>> As for how to process multiple arguments to a "set" command,
>> one way would be to stage the value in a string parameter,
>> and then have a set handler post-process the result.
>
> I think using commas systematically is making it worse for ourselves,
> since it prevents us from using gdb_buildargv to parse the command
> arguments for us. Commas also have a meaning in C, so arguably
> they could be used in expressions as well. But, if that's the way
> people prefer, then having a standard gdb_buildargv-like API that
> everyone consistently uses will make it easier for me to accept
> that decision.

fwiw, I *like* buildargv.  But quoting expressions, not so much. :-)

In the end, for something like this I'm ok with either.


  parent reply	other threads:[~2014-11-24 15:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23  4:24 Joel Brobecker
2014-11-23  9:32 ` Andreas Schwab
2014-11-23  9:53   ` Joel Brobecker
2014-11-24  5:39     ` Doug Evans
2014-11-24  7:13       ` Joel Brobecker
2014-11-24 10:38         ` Andreas Schwab
2014-11-24 15:36         ` Doug Evans [this message]
2015-04-13 15:32         ` Tedeschi, Walfred
2015-04-14 12:49           ` Joel Brobecker
2015-04-20  5:44             ` Doug Evans
2015-04-20 15:25               ` Joel Brobecker
2015-04-20 15:30               ` Tedeschi, Walfred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP9bCMTSTGAippgSkeY00j75Tnarw1qq6S0Q=s7ns1drpYGNOA@mail.gmail.com' \
    --to=xdje42@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox