From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
To: Joel Brobecker <brobecker@adacore.com>, Doug Evans <xdje42@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: RFC: "set" command with 2 arguments instead of one?
Date: Mon, 13 Apr 2015 15:32:00 -0000 [thread overview]
Message-ID: <AC542571535E904D8E8ADAE745D60B192FA0A7CD@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20141124071258.GI5774@adacore.com>
Joel, Andreas, Doug and all,
Sorry for the long delay here. Now I could come back to the patches again.
Was there any outcome on that discussion. How do you think I could use the multiple arguments?
Thanks a lot and regards,
-Fred
-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Joel Brobecker
Sent: Monday, November 24, 2014 8:13 AM
To: Doug Evans
Cc: Andreas Schwab; gdb-patches@sourceware.org
Subject: Re: RFC: "set" command with 2 arguments instead of one?
> This feels like a case where we need to at least think about some
> future-proofing.
> One way some commands separate expressions is with commas.
> I'm not fond of optional commas (setting aside the thread on info
> macro -at LOCATION,).
> IOW, if it turns out that we want to use commas down the road to
> separate expressions here, then I'd prefer the commas be required
> today.
> E.g., set mpx bound ADDR, LBOUND, UBOUND
> As for how to process multiple arguments to a "set" command, one way
> would be to stage the value in a string parameter, and then have a set
> handler post-process the result.
I think using commas systematically is making it worse for ourselves, since it prevents us from using gdb_buildargv to parse the command arguments for us. Commas also have a meaning in C, so arguably they could be used in expressions as well. But, if that's the way people prefer, then having a standard gdb_buildargv-like API that everyone consistently uses will make it easier for me to accept that decision.
--
Joel
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2015-04-13 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 4:24 Joel Brobecker
2014-11-23 9:32 ` Andreas Schwab
2014-11-23 9:53 ` Joel Brobecker
2014-11-24 5:39 ` Doug Evans
2014-11-24 7:13 ` Joel Brobecker
2014-11-24 10:38 ` Andreas Schwab
2014-11-24 15:36 ` Doug Evans
2015-04-13 15:32 ` Tedeschi, Walfred [this message]
2015-04-14 12:49 ` Joel Brobecker
2015-04-20 5:44 ` Doug Evans
2015-04-20 15:25 ` Joel Brobecker
2015-04-20 15:30 ` Tedeschi, Walfred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC542571535E904D8E8ADAE745D60B192FA0A7CD@IRSMSX104.ger.corp.intel.com \
--to=walfred.tedeschi@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox