From: Doug Evans <xdje42@gmail.com>
To: Andy Wingo <wingo@igalia.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2
Date: Sat, 12 Apr 2014 16:47:00 -0000 [thread overview]
Message-ID: <CAP9bCMS0SH+K5A644OhqBuOV8DmLi0Ov_DZhc=mUacdrBV+Lxw@mail.gmail.com> (raw)
In-Reply-To: <m3eh12tsag.fsf@sspiff.org>
On Sat, Apr 12, 2014 at 9:40 AM, Doug Evans <xdje42@gmail.com> wrote:
> This is ok with two nits:
>
> 1) ChangeLog entries are included in the email as they appear in the file
> itself (but not as a patch). E.g., for future reference, replace
>
> * gdb/configure:
> * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2.
>
> with
>
> 2014-04-09 Andy Wingo <wingo@igalia.com>
>
> * gdb/configure:
> * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2.
Oops. Make that
2014-04-09 Andy Wingo <wingo@igalia.com>
* configure: Regenerate.
* configure.ac (try_guile_versions): Allow building with guile 2.2.
Paths in ChangeLog files are relative to the location of the ChangeLog file.
And convention is to write "Regenerate" for machine generated files.
Plus, instead of "replace" I should have probably said "in addition to".
Feel free to include whatever git spits out of course, but current
community rules require the ChangeLog entry included in the emailed
patch as shown above.
[There is debate on how to improve this, but I don't think the
community has agreed to anything yet.]
next prev parent reply other threads:[~2014-04-12 16:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 16:14 [PATCH 0/8] Cleanups to Guile extension interface Andy Wingo
2014-04-09 16:14 ` [PATCH 3/9] Fix excess parentheses in Guile extension examples Andy Wingo
2014-04-09 16:14 ` [PATCH 5/9] Rename "gsmob" in Guile interface to "gdb object" Andy Wingo
2014-04-12 18:46 ` Doug Evans
2014-04-17 9:39 ` Andy Wingo
2014-04-17 9:46 ` Eli Zaretskii
2014-04-09 16:14 ` [PATCH 2/9] Define and export Guile classes for all GDB object types Andy Wingo
2014-04-12 18:32 ` Doug Evans
2014-04-09 16:14 ` [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2 Andy Wingo
2014-04-12 16:40 ` Doug Evans
2014-04-12 16:47 ` Doug Evans [this message]
2014-04-17 9:04 ` Andy Wingo
2014-04-09 16:14 ` [PATCH 8/9] Remove useless Guile SMOB marking functions Andy Wingo
2014-04-12 19:50 ` Doug Evans
2014-04-09 16:14 ` [PATCH 9/9] Remove a useless Guile finalizer Andy Wingo
2014-04-12 20:18 ` Doug Evans
2014-04-14 12:12 ` Ludovic Courtès
2014-04-14 21:39 ` Doug Evans
2014-04-15 9:29 ` Ludovic Courtès
2014-04-15 15:30 ` Doug Evans
2014-04-17 10:07 ` Andy Wingo
2014-04-09 16:14 ` [PATCH 6/9] Remove Guile GDB object property mechanism Andy Wingo
2014-04-12 19:23 ` Doug Evans
2014-04-17 9:54 ` Andy Wingo
2014-04-09 16:14 ` [PATCH 7/9] Remove Guile mark functions that don't mark anything Andy Wingo
2014-04-12 19:29 ` Doug Evans
2014-04-17 9:48 ` Andy Wingo
2014-04-20 19:34 ` Doug Evans
2014-04-22 7:40 ` Andy Wingo
2014-04-29 11:51 ` Ludovic Courtès
2014-04-09 16:14 ` [PATCH 4/9] Fix typos in documentation of Guile `execute' function Andy Wingo
-- strict thread matches above, loose matches on Subject: below --
2014-04-09 16:09 [PATCH 0/8] Cleanups to Guile extension interface Andy Wingo
2014-04-09 16:09 ` [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2 Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9bCMS0SH+K5A644OhqBuOV8DmLi0Ov_DZhc=mUacdrBV+Lxw@mail.gmail.com' \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox