From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15238 invoked by alias); 12 Apr 2014 16:47:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15228 invoked by uid 89); 12 Apr 2014 16:47:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f52.google.com Received: from mail-yh0-f52.google.com (HELO mail-yh0-f52.google.com) (209.85.213.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Apr 2014 16:47:48 +0000 Received: by mail-yh0-f52.google.com with SMTP id c41so6513228yho.39 for ; Sat, 12 Apr 2014 09:47:46 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.236.157.167 with SMTP id o27mr1881295yhk.127.1397321266455; Sat, 12 Apr 2014 09:47:46 -0700 (PDT) Received: by 10.170.214.130 with HTTP; Sat, 12 Apr 2014 09:47:46 -0700 (PDT) In-Reply-To: References: <1397060028-18158-1-git-send-email-wingo@igalia.com> <1397060028-18158-2-git-send-email-wingo@igalia.com> Date: Sat, 12 Apr 2014 16:47:00 -0000 Message-ID: Subject: Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2 From: Doug Evans To: Andy Wingo Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00237.txt.bz2 On Sat, Apr 12, 2014 at 9:40 AM, Doug Evans wrote: > This is ok with two nits: > > 1) ChangeLog entries are included in the email as they appear in the file > itself (but not as a patch). E.g., for future reference, replace > > * gdb/configure: > * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. > > with > > 2014-04-09 Andy Wingo > > * gdb/configure: > * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. Oops. Make that 2014-04-09 Andy Wingo * configure: Regenerate. * configure.ac (try_guile_versions): Allow building with guile 2.2. Paths in ChangeLog files are relative to the location of the ChangeLog file. And convention is to write "Regenerate" for machine generated files. Plus, instead of "replace" I should have probably said "in addition to". Feel free to include whatever git spits out of course, but current community rules require the ChangeLog entry included in the emailed patch as shown above. [There is debate on how to improve this, but I don't think the community has agreed to anything yet.]