Re: [PATCH] Sync readline/ to version 7.0 alpha

[Doug Evans <xdje42@gmail.com>]

On Sat, Jul 25, 2015 at 8:33 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 07/15/2015 03:35 AM, Patrick Palka wrote:
>>> This patch syncs our upstream copy of readline from version 6.2 to the
>>> latest version, 7.0 alpha (released July 10 2015).
>>>
>>> I essentially copied what was done the last time readline was synced,
>>> when Jan updated to readline 6.2 in 2011:
>>> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
>>
>>
>>> Getting this kind of change in at the start of the GDB 7.11 development
>>> cycle will allow us to get a lot of passive testing from developers and
>>> from bleeding-edge users.
>>
>> I agree; if this helps find readline issues that affect GDB before
>> readline is released, it'll be a win, because distros tend to use the
>> system readline instead of the one we bundle.
>>
>>> [And as new versions of readline 7.0 are
>>> released, I will try to sync our local copy promptly.]
>>>
>>
>> Thanks.
>>
>>> Since the patch is too big to send inline, I pushed it to
>>> users/ppalka/readline-7.0-update.  Hopefully that is more convenient that
>>> sending it as a compressed attachment.
>>
>> Indeed it is.  Thanks.
>>
>>>
>>> readline/ChangeLog.gdb:
>>>
>>>       Import readline 7.0 alpha
>>>       * configure: Regenerate.
>>>       * examples/rlfe/configure: Regenerate.
>>>
>>> gdb/ChangeLog:
>>>
>>>       * completer.c (gdb_printable_part): Sync with readline function
>>>       it is based off of.
>>>
>>> gdb/testsuite/ChangeLog:
>>>
>>>       * gdb.gdb/selftest.exp (test_with_self): Update test to now
>>>       expect the GDB inferior to no longer immediately stop after
>>>       being resumed with "signal SIGINT".
>>
>> Looks good to me.
>
> Thanks for reviewing.  I pushed this patch earlier today and not
> surprisingly the buildbot caught some build failures.  The ultimate
> cause of these failures is that readline now builds shared libraries
> by default alongside static libraries.  I pushed a patch that disables
> the building of readline's shared libraries by default.

Another build failure:

../../testsuite-random/readline/display.c: In function ‘rl_redisplay’:
../../testsuite-random/readline/display.c:1032:12: error: ‘mb_cur_max’
undeclared (first use in this function)
        if (mb_cur_max > 1 && rl_byte_oriented == 0)
            ^
../../testsuite-random/readline/display.c:1032:12: note: each
undeclared identifier is reported only once for each function it
appears in

A lot of uses of mb_cur_max are no longer protected with
#ifdef HANDLE_MULTIBYTE
yet its definition (in rl_redisplay) still is.

I don't know what the right fix is, but we need to get this
fixed asap.