From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118976 invoked by alias); 25 Jul 2015 19:15:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118964 invoked by uid 89); 25 Jul 2015 19:15:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f181.google.com Received: from mail-yk0-f181.google.com (HELO mail-yk0-f181.google.com) (209.85.160.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 25 Jul 2015 19:15:28 +0000 Received: by ykfw194 with SMTP id w194so42782042ykf.0 for ; Sat, 25 Jul 2015 12:15:26 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.170.126.198 with SMTP id s189mr21993885ykb.78.1437851726537; Sat, 25 Jul 2015 12:15:26 -0700 (PDT) Received: by 10.13.233.198 with HTTP; Sat, 25 Jul 2015 12:15:26 -0700 (PDT) In-Reply-To: References: <1436927724-4059-1-git-send-email-patrick@parcs.ath.cx> <55B1FB46.5000106@redhat.com> Date: Sat, 25 Jul 2015 19:15:00 -0000 Message-ID: Subject: Re: [PATCH] Sync readline/ to version 7.0 alpha From: Doug Evans To: Patrick Palka Cc: Pedro Alves , "gdb-patches@sourceware.org" , Eli Zaretskii , Sergio Durigan Junior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00758.txt.bz2 On Sat, Jul 25, 2015 at 8:33 AM, Patrick Palka wrote: > On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves wrote: >> On 07/15/2015 03:35 AM, Patrick Palka wrote: >>> This patch syncs our upstream copy of readline from version 6.2 to the >>> latest version, 7.0 alpha (released July 10 2015). >>> >>> I essentially copied what was done the last time readline was synced, >>> when Jan updated to readline 6.2 in 2011: >>> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html >> >> >>> Getting this kind of change in at the start of the GDB 7.11 development >>> cycle will allow us to get a lot of passive testing from developers and >>> from bleeding-edge users. >> >> I agree; if this helps find readline issues that affect GDB before >> readline is released, it'll be a win, because distros tend to use the >> system readline instead of the one we bundle. >> >>> [And as new versions of readline 7.0 are >>> released, I will try to sync our local copy promptly.] >>> >> >> Thanks. >> >>> Since the patch is too big to send inline, I pushed it to >>> users/ppalka/readline-7.0-update. Hopefully that is more convenient th= at >>> sending it as a compressed attachment. >> >> Indeed it is. Thanks. >> >>> >>> readline/ChangeLog.gdb: >>> >>> Import readline 7.0 alpha >>> * configure: Regenerate. >>> * examples/rlfe/configure: Regenerate. >>> >>> gdb/ChangeLog: >>> >>> * completer.c (gdb_printable_part): Sync with readline function >>> it is based off of. >>> >>> gdb/testsuite/ChangeLog: >>> >>> * gdb.gdb/selftest.exp (test_with_self): Update test to now >>> expect the GDB inferior to no longer immediately stop after >>> being resumed with "signal SIGINT". >> >> Looks good to me. > > Thanks for reviewing. I pushed this patch earlier today and not > surprisingly the buildbot caught some build failures. The ultimate > cause of these failures is that readline now builds shared libraries > by default alongside static libraries. I pushed a patch that disables > the building of readline's shared libraries by default. Another build failure: ../../testsuite-random/readline/display.c: In function =E2=80=98rl_redispla= y=E2=80=99: ../../testsuite-random/readline/display.c:1032:12: error: =E2=80=98mb_cur_m= ax=E2=80=99 undeclared (first use in this function) if (mb_cur_max > 1 && rl_byte_oriented =3D=3D 0) ^ ../../testsuite-random/readline/display.c:1032:12: note: each undeclared identifier is reported only once for each function it appears in A lot of uses of mb_cur_max are no longer protected with #ifdef HANDLE_MULTIBYTE yet its definition (in rl_redisplay) still is. I don't know what the right fix is, but we need to get this fixed asap.