Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] fix lib/pascal.exp dest snafu
Date: Mon, 06 Apr 2015 15:49:00 -0000	[thread overview]
Message-ID: <CAP9bCMQU_gG0ZNOreH81z1r2XW7HF3fKyt6Y=CGv8dzizcO=8w@mail.gmail.com> (raw)
In-Reply-To: <54db3bc4.a2ac440a.5576.1b7bSMTPIN_ADDED_BROKEN@mx.google.com>

On Wed, Feb 11, 2015 at 3:21 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
>  Hi Doug,
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Doug Evans
>> Envoyé : mercredi 11 février 2015 07:18
>> À : gdb-patches@sourceware.org; pierre.muller@ics-cnrs.unistra.fr
>> Objet : [PATCH] fix lib/pascal.exp dest snafu
>>
>> The "dest" parameter to fpc_compile/gpc_compile is the name of
>> compilation destination file, not a board name.
>>
>> This patch fixes this by using names consistent with
>> lib/future.exp:gdb_default_target_compile.
>
>   Thank you very much for finding out this
> horrible mistake.
>
> Patch approved,
>
> Pierre Muller
> as pascal language maintainer.
>
>> 2015-02-10  Doug Evans  <xdje42@gmail.com>
>>
>>       * lib/pascal.exp (gpc_compile): Rename dest arg to destfile.
>>       Fix dest parameter to board_info.
>>       (fpc_compile): Ditto.
>>       (gdb_compile_pascal): Rename dest arg to destfile.

Committed.


      parent reply	other threads:[~2015-04-06 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  6:18 Doug Evans
2015-02-11 11:22 ` Pierre Muller
     [not found] ` <54db3bc4.a2ac440a.5576.1b7bSMTPIN_ADDED_BROKEN@mx.google.com>
2015-04-06 15:49   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP9bCMQU_gG0ZNOreH81z1r2XW7HF3fKyt6Y=CGv8dzizcO=8w@mail.gmail.com' \
    --to=xdje42@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox