From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121559-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30304 invoked by alias); 6 Apr 2015 15:49:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30284 invoked by uid 89); 6 Apr 2015 15:49:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_20,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qg0-f50.google.com
Received: from mail-qg0-f50.google.com (HELO mail-qg0-f50.google.com) (209.85.192.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 06 Apr 2015 15:49:26 +0000
Received: by qgej70 with SMTP id j70so10971478qge.2        for <gdb-patches@sourceware.org>; Mon, 06 Apr 2015 08:49:24 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.140.80.176 with SMTP id c45mr17494750qgd.101.1428335364513; Mon, 06 Apr 2015 08:49:24 -0700 (PDT)
Received: by 10.229.119.10 with HTTP; Mon, 6 Apr 2015 08:49:24 -0700 (PDT)
In-Reply-To: <54db3bc4.a2ac440a.5576.1b7bSMTPIN_ADDED_BROKEN@mx.google.com>
References: <m3d25hj7jz.fsf@sspiff.org>	<54db3bc4.a2ac440a.5576.1b7bSMTPIN_ADDED_BROKEN@mx.google.com>
Date: Mon, 06 Apr 2015 15:49:00 -0000
Message-ID: <CAP9bCMQU_gG0ZNOreH81z1r2XW7HF3fKyt6Y=CGv8dzizcO=8w@mail.gmail.com>
Subject: Re: [PATCH] fix lib/pascal.exp dest snafu
From: Doug Evans <xdje42@gmail.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00147.txt.bz2

On Wed, Feb 11, 2015 at 3:21 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
>  Hi Doug,
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Doug Evans
>> Envoy=C3=A9 : mercredi 11 f=C3=A9vrier 2015 07:18
>> =C3=80 : gdb-patches@sourceware.org; pierre.muller@ics-cnrs.unistra.fr
>> Objet : [PATCH] fix lib/pascal.exp dest snafu
>>
>> The "dest" parameter to fpc_compile/gpc_compile is the name of
>> compilation destination file, not a board name.
>>
>> This patch fixes this by using names consistent with
>> lib/future.exp:gdb_default_target_compile.
>
>   Thank you very much for finding out this
> horrible mistake.
>
> Patch approved,
>
> Pierre Muller
> as pascal language maintainer.
>
>> 2015-02-10  Doug Evans  <xdje42@gmail.com>
>>
>>       * lib/pascal.exp (gpc_compile): Rename dest arg to destfile.
>>       Fix dest parameter to board_info.
>>       (fpc_compile): Ditto.
>>       (gdb_compile_pascal): Rename dest arg to destfile.

Committed.