* Re: Oh dear. I regret to inform you that commit 'Add support for disassembling WebAssembly opcodes.' might be unfortunate
[not found] <E1cwHis-0004uN-3V@kwanyin.sergiodj.net>
@ 2017-04-07 0:33 ` Pip Cet
2017-04-07 8:26 ` Yao Qi
0 siblings, 1 reply; 2+ messages in thread
From: Pip Cet @ 2017-04-07 0:33 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 6577 bytes --]
Sorry about that. I'm attaching a patch to fix this build issue.
Suggested change log entry:
2017-04-06 Pip Cet <pipcet@gmail.com>
* wasm32-dis.c (print_insn_wasm32): Use a fixed value (valid for
IEEE 754 doubles) instead of DECIMAL_DIG.
On Fri, Apr 7, 2017 at 12:25 AM, <gdb-buildbot@sergiodj.net> wrote:
> My lords, ladies, gentlemen, members of the public.
>
> It is a matter of great regret and sadness to inform you that commit:
>
> Add support for disassembling WebAssembly opcodes.
> 62ecb94c4a2929c1aace3fb5470d2a5100255811
>
> might have made GDB unwell. Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.
>
> Please note that if you are reading this message on gdb-patches, there might
> be other builders broken.
>
> You can find more details about the unfortunate breakage below.
>
> Cheers,
>
> Your GDB BuildBot.
>
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>
> Buildslave:
> ubuntu-trusty-aarch32-1
>
> Full Build URL:
> <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/336>
>
> Commit(s) tested:
> 62ecb94c4a2929c1aace3fb5470d2a5100255811
>
> Author(s) (in the same order as the commits):
> Pip Cet <pipcet@gmail.com>
>
> Subject:
> Add support for disassembling WebAssembly opcodes.
>
> Testsuite log (gdb.sum and gdb.log) URL(s):
> <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/62/62ecb94c4a2929c1aace3fb5470d2a5100255811/>
>
> *** Failed to compiled GDB. ***
> ============================
>
> +++ The full log is too big to be posted here.
> +++ These are the last 100 lines of it.
>
> checking netinet/in.h presence... yes
> checking for netinet/in.h... yes
> checking for sys/socket.h... (cached) yes
> checking netdb.h usability... yes
> checking netdb.h presence... yes
> checking for netdb.h... yes
> checking netinet/tcp.h usability... yes
> checking netinet/tcp.h presence... yes
> checking for netinet/tcp.h... yes
> checking arpa/inet.h usability... yes
> checking arpa/inet.h presence... yes
> checking for arpa/inet.h... yes
> checking for pid_t... (cached) yes
> checking for vfork.h... (cached) no
> checking for fork... (cached) yes
> checking for vfork... (cached) yes
> checking for working fork... (cached) yes
> checking for working vfork... (cached) yes
> checking for getauxval... (cached) yes
> checking for pread... (cached) yes
> checking for pwrite... (cached) yes
> checking for pread64... (cached) yes
> checking for setns... (cached) yes
> checking for ANSI C header files... (cached) yes
> checking for working alloca.h... (cached) yes
> checking for alloca... (cached) yes
> checking for nl_langinfo and CODESET... (cached) yes
> checking for linux/perf_event.h... (cached) yes
> checking for locale.h... (cached) yes
> checking for memory.h... (cached) yes
> checking for signal.h... (cached) yes
> checking for sys/resource.h... (cached) yes
> checking for sys/socket.h... (cached) yes
> checking for sys/syscall.h... (cached) yes
> checking for sys/un.h... (cached) yes
> checking for sys/wait.h... (cached) yes
> checking for thread_db.h... (cached) yes
> checking for wait.h... (cached) yes
> checking for fdwalk... (cached) no
> checking for getrlimit... (cached) yes
> checking for pipe... (cached) yes
> checking for pipe2... (cached) yes
> checking for socketpair... (cached) yes
> checking for sigaction... (cached) yes
> checking whether strerror is declared... (cached) yes
> checking whether strstr is declared... (cached) yes
> checking for sigsetjmp... (cached) yes
> checking for sys/ptrace.h... (cached) yes
> checking for ptrace.h... (cached) no
> checking whether ptrace is declared... (cached) yes
> checking return type of ptrace... (cached) long
> checking types of arguments for ptrace... (cached) enum __ptrace_request,int,long,long
> checking for ust... no
> checking compiler warning flags... -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wformat-nonliteral -Werror
> checking for dladdr... yes
> checking for long long... (cached) yes
> checking size of long long... (cached) 8
> checking whether basename is declared... (cached) yes
> checking whether ffs is declared... (cached) yes
> checking whether asprintf is declared... (cached) yes
> checking whether vasprintf is declared... (cached) yes
> checking whether snprintf is declared... (cached) yes
> checking whether vsnprintf is declared... (cached) yes
> checking whether strtol is declared... (cached) yes
> checking whether strtoul is declared... (cached) yes
> checking whether strtoll is declared... (cached) yes
> checking whether strtoull is declared... (cached) yes
> checking whether strverscmp is declared... (cached) yes
> checking whether strerror is declared... (cached) yes
> checking whether perror is declared... yes
> checking whether vasprintf is declared... (cached) yes
> checking whether vsnprintf is declared... (cached) yes
> checking for struct stat.st_blocks... (cached) yes
> checking for struct stat.st_blksize... (cached) yes
> checking for struct user_regs_struct.fs_base... (cached) no
> checking for struct user_regs_struct.gs_base... (cached) no
> checking for socklen_t... (cached) yes
> checking for Elf32_auxv_t... yes
> checking for Elf64_auxv_t... yes
> checking for PTRACE_GETREGS... yes
> checking for PTRACE_GETFPXREGS... yes
> checking for lwpid_t in sys/procfs.h... (cached) yes
> checking for psaddr_t in sys/procfs.h... (cached) yes
> checking for prgregset_t in sys/procfs.h... (cached) yes
> checking for prfpregset_t in sys/procfs.h... (cached) yes
> checking for elf_fpregset_t in sys/procfs.h... yes
> checking for dlopen in -ldl... yes
> checking for the dynamic export flag... -Wl,--dynamic-list
> checking for TD_VERSION... yes
> checking whether the target supports __sync_*_compare_and_swap... yes
> checking whether ADDR_NO_RANDOMIZE is declared... (cached) yes
> configure: updating cache .././config.cache
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating config.h
> config.status: executing depdir commands
> mkdir -p -- .deps
> make[1]: Leaving directory `/home/qiyao/buildbot/ubuntu-aarch32-m32/build'
> make: *** [all] Error 2
> ============================
>
[-- Attachment #2: binutils-wasm-009.diff --]
[-- Type: text/plain, Size: 1540 bytes --]
diff --git a/opcodes/wasm32-dis.c b/opcodes/wasm32-dis.c
index 80e4ffe81a..f150163a80 100644
--- a/opcodes/wasm32-dis.c
+++ b/opcodes/wasm32-dis.c
@@ -23,13 +23,22 @@
#include "opintl.h"
#include "safe-ctype.h"
#include "floatformat.h"
-#include <float.h>
#include "libiberty.h"
#include "elf-bfd.h"
#include "elf/internal.h"
#include "elf/wasm32.h"
#include <stdint.h>
+/* Number of decimal digits, n, such that any floating-point number in the
+ widest supported floating type with pmax radix b digits can be rounded
+ to a floating-point number with n decimal digits and back again without
+ change to the value,
+
+ pmax * log10(b) if b is a power of 10
+ ceil(1 + pmax * log10(b)) otherwise
+*/
+#define DECIMAL_DIG_IEEE754 17
+
/* Type names for blocks and signatures. */
#define BLOCK_TYPE_NONE 0x40
#define BLOCK_TYPE_I32 0x7f
@@ -405,7 +414,7 @@ print_insn_wasm32 (bfd_vma pc, struct disassemble_info *info)
if (ret < 0)
return -1;
len += ret;
- prin (stream, " %.*g", DECIMAL_DIG, fconstant);
+ prin (stream, " %.*g", DECIMAL_DIG_IEEE754, fconstant);
break;
case wasm_constant_f64:
@@ -413,7 +422,7 @@ print_insn_wasm32 (bfd_vma pc, struct disassemble_info *info)
if (ret < 0)
return -1;
len += ret;
- prin (stream, " %.*g", DECIMAL_DIG, fconstant);
+ prin (stream, " %.*g", DECIMAL_DIG_IEEE754, fconstant);
break;
case wasm_call:
^ permalink raw reply [flat|nested] 2+ messages in thread