Bad Indentation

Bad Indentation

[Abhijit Halder]

Hi,

I've found the following indentation problem. Can someone plz correct the same.

#cvs diff gdb/remote.c

Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.461
diff -r1.461 remote.c
4883c4883
<   }
---
> }


Thanks,
Abhijit Halder

Re: Bad Indentation

[Abhijit Halder]

On Sat, Sep 3, 2011 at 3:02 PM, Abhijit Halder
<abhijit.k.halder@gmail.com> wrote:
> Hi,
>
> I've found the following indentation problem. Can someone plz correct the same.
>
> #cvs diff gdb/remote.c
>
> Index: gdb/remote.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote.c,v
> retrieving revision 1.461
> diff -r1.461 remote.c
> 4883c4883
> <   }
> ---
>> }
>
>
> Thanks,
> Abhijit Halder
>

In the same context I did an exercise and found the following:

# grep -I --include=*.[ch] -r "^[ ]\{8,\}" gdb-top/ | wc -l
71233

Since our convention is converting 8 consecutive space into a tab
character, the above result seems to me the violation of that rule.
Can we run some script to correct the same?

Thanks,
Abhijit Halder

Re: Bad Indentation

[Tom Tromey]

>>>>> "Abhijit" == Abhijit Halder <abhijit.k.halder@gmail.com> writes:

Abhijit> Since our convention is converting 8 consecutive space into a tab
Abhijit> character, the above result seems to me the violation of that rule.
Abhijit> Can we run some script to correct the same?

I didn't see a response to this.

I'm mildly against such changes.  They make branch merges harder and
don't notably contribute to source clarity.

I won't object if someone wants to write this and some other reviewer
thinks it is worth committing.

Tom

Re: Bad Indentation

[Joel Brobecker]

> I'm mildly against such changes.  They make branch merges harder and
> don't notably contribute to source clarity.

Same here. (I'm still very much in favor of banning tabs altogether,
they play tricks when displaying diffs, because sometimes, and they
are also a pain if the editor is not configure right - the only people
who don't mind are people using emacs).

-- 
Joel