Some code-cleanup

[Abhijit Halder <abhijit.k.halder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

I have seen in one place (write_exp_elt) that we are passing an union
by value and not by reference.
Please let me know whether we do have any specific reason of doing
that. I am submitting the patch as an attachment. Please review the
same.

Thanks,
Abhijit Halder

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 4641 bytes --]

Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.13320
diff -a -p -u -r1.13320 ChangeLog
--- gdb/ChangeLog	11 Sep 2011 09:54:16 -0000	1.13320
+++ gdb/ChangeLog	12 Sep 2011 15:00:22 -0000
@@ -1,3 +1,19 @@
+2011-09-12  Abhijit Halder  <abhijit.k.halder@gmail.com>
+
+	Code cleanup.
+	* gdb/parse.c (write_exp_elt): Change the argument to pass a pointer
+	of union exp_element instead of an element of the same.
+	* (write_exp_elt_opcode): Change argument of write_exp_elt call.
+	* (write_exp_elt_sym): Change argument of write_exp_elt call.
+	* (write_exp_elt_block): Change argument of write_exp_elt call.
+	* (write_exp_elt_objfile): Change argument of write_exp_elt call.
+	* (write_exp_elt_longcst): Change argument of write_exp_elt call.
+	* (write_exp_elt_dblcst): Change argument of write_exp_elt call.
+	* (write_exp_elt_decfloatcst): Change argument of write_exp_elt call.
+	* (write_exp_elt_type): Change argument of write_exp_elt call.
+	* (write_exp_elt_intern): Change argument of write_exp_elt call.
+	* src/sim/ppc/dp-bit.c (unpack_d): Change the formatting.
+
 2011-09-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Code cleanup.
Index: gdb/parse.c
===================================================================
RCS file: /cvs/src/src/gdb/parse.c,v
retrieving revision 1.110
diff -a -p -u -r1.110 parse.c
--- gdb/parse.c	17 Jun 2011 20:24:22 -0000	1.110
+++ gdb/parse.c	12 Sep 2011 15:00:23 -0000
@@ -190,7 +190,7 @@ free_funcalls (void *ignore)
     }
 }
 \f
-/* This page contains the functions for adding data to the  struct expression
+/* This page contains the functions for adding data to the struct expression
    being constructed.  */
 
 /* Add one element to the end of the expression.  */
@@ -199,7 +199,7 @@ free_funcalls (void *ignore)
    a register through here.  */
 
 void
-write_exp_elt (union exp_element expelt)
+write_exp_elt (union exp_element *expelt)
 {
   if (expout_ptr >= expout_size)
     {
@@ -208,7 +208,7 @@ write_exp_elt (union exp_element expelt)
 	xrealloc ((char *) expout, sizeof (struct expression)
 		  + EXP_ELEM_TO_BYTES (expout_size));
     }
-  expout->elts[expout_ptr++] = expelt;
+  expout->elts[expout_ptr++] = *expelt;
 }
 
 void
@@ -218,7 +218,7 @@ write_exp_elt_opcode (enum exp_opcode ex
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.opcode = expelt;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -228,7 +228,7 @@ write_exp_elt_sym (struct symbol *expelt
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.symbol = expelt;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -238,7 +238,7 @@ write_exp_elt_block (struct block *b)
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.block = b;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -248,7 +248,7 @@ write_exp_elt_objfile (struct objfile *o
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.objfile = objfile;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -258,7 +258,7 @@ write_exp_elt_longcst (LONGEST expelt)
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.longconst = expelt;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -268,7 +268,7 @@ write_exp_elt_dblcst (DOUBLEST expelt)
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.doubleconst = expelt;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -280,7 +280,7 @@ write_exp_elt_decfloatcst (gdb_byte expe
   for (index = 0; index < 16; index++)
     tmp.decfloatconst[index] = expelt[index];
 
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -290,7 +290,7 @@ write_exp_elt_type (struct type *expelt)
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.type = expelt;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 void
@@ -300,7 +300,7 @@ write_exp_elt_intern (struct internalvar
 
   memset (&tmp, 0, sizeof (union exp_element));
   tmp.internalvar = expelt;
-  write_exp_elt (tmp);
+  write_exp_elt (&tmp);
 }
 
 /* Add a string constant to the end of the expression.
Index: sim/ppc/dp-bit.c
===================================================================
RCS file: /cvs/src/src/sim/ppc/dp-bit.c,v
retrieving revision 1.7
diff -a -p -u -r1.7 dp-bit.c
--- sim/ppc/dp-bit.c	1 Jan 2011 15:34:04 -0000	1.7
+++ sim/ppc/dp-bit.c	12 Sep 2011 15:00:26 -0000
@@ -408,7 +408,7 @@ pack_d ( fp_number_type *  src)
 }
 
 static void
-unpack_d (FLO_union_type * src, fp_number_type * dst)
+unpack_d (FLO_union_type *src, fp_number_type *dst)
 {
   fractype fraction = src->bits.fraction;