From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7271 invoked by alias); 12 Sep 2011 15:06:16 -0000 Received: (qmail 7257 invoked by uid 22791); 12 Sep 2011 15:06:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Sep 2011 15:06:01 +0000 Received: by eye22 with SMTP id 22so287712eye.0 for ; Mon, 12 Sep 2011 08:06:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.1.200 with SMTP id 50mr2831459wed.33.1315839960000; Mon, 12 Sep 2011 08:06:00 -0700 (PDT) Received: by 10.216.159.205 with HTTP; Mon, 12 Sep 2011 08:05:59 -0700 (PDT) Date: Mon, 12 Sep 2011 15:08:00 -0000 Message-ID: Subject: Some code-cleanup From: Abhijit Halder To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016364d2c7965a8ac04acbfddf0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00193.txt.bz2 --0016364d2c7965a8ac04acbfddf0 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 266 I have seen in one place (write_exp_elt) that we are passing an union by value and not by reference. Please let me know whether we do have any specific reason of doing that. I am submitting the patch as an attachment. Please review the same. Thanks, Abhijit Halder --0016364d2c7965a8ac04acbfddf0 Content-Type: application/octet-stream; name=patch Content-Disposition: attachment; filename=patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_gshl4bmu0 Content-length: 6292 SW5kZXg6IGdkYi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9DaGFuZ2VMb2csdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMTMzMjAKZGlmZiAtYSAtcCAtdSAtcjEuMTMzMjAg Q2hhbmdlTG9nCi0tLSBnZGIvQ2hhbmdlTG9nCTExIFNlcCAyMDExIDA5OjU0 OjE2IC0wMDAwCTEuMTMzMjAKKysrIGdkYi9DaGFuZ2VMb2cJMTIgU2VwIDIw MTEgMTU6MDA6MjIgLTAwMDAKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wOS0x MiAgQWJoaWppdCBIYWxkZXIgIDxhYmhpaml0LmsuaGFsZGVyQGdtYWlsLmNv bT4KKworCUNvZGUgY2xlYW51cC4KKwkqIGdkYi9wYXJzZS5jICh3cml0ZV9l eHBfZWx0KTogQ2hhbmdlIHRoZSBhcmd1bWVudCB0byBwYXNzIGEgcG9pbnRl cgorCW9mIHVuaW9uIGV4cF9lbGVtZW50IGluc3RlYWQgb2YgYW4gZWxlbWVu dCBvZiB0aGUgc2FtZS4KKwkqICh3cml0ZV9leHBfZWx0X29wY29kZSk6IENo YW5nZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0IGNhbGwuCisJKiAod3Jp dGVfZXhwX2VsdF9zeW0pOiBDaGFuZ2UgYXJndW1lbnQgb2Ygd3JpdGVfZXhw X2VsdCBjYWxsLgorCSogKHdyaXRlX2V4cF9lbHRfYmxvY2spOiBDaGFuZ2Ug YXJndW1lbnQgb2Ygd3JpdGVfZXhwX2VsdCBjYWxsLgorCSogKHdyaXRlX2V4 cF9lbHRfb2JqZmlsZSk6IENoYW5nZSBhcmd1bWVudCBvZiB3cml0ZV9leHBf ZWx0IGNhbGwuCisJKiAod3JpdGVfZXhwX2VsdF9sb25nY3N0KTogQ2hhbmdl IGFyZ3VtZW50IG9mIHdyaXRlX2V4cF9lbHQgY2FsbC4KKwkqICh3cml0ZV9l eHBfZWx0X2RibGNzdCk6IENoYW5nZSBhcmd1bWVudCBvZiB3cml0ZV9leHBf ZWx0IGNhbGwuCisJKiAod3JpdGVfZXhwX2VsdF9kZWNmbG9hdGNzdCk6IENo YW5nZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0IGNhbGwuCisJKiAod3Jp dGVfZXhwX2VsdF90eXBlKTogQ2hhbmdlIGFyZ3VtZW50IG9mIHdyaXRlX2V4 cF9lbHQgY2FsbC4KKwkqICh3cml0ZV9leHBfZWx0X2ludGVybik6IENoYW5n ZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0IGNhbGwuCisJKiBzcmMvc2lt L3BwYy9kcC1iaXQuYyAodW5wYWNrX2QpOiBDaGFuZ2UgdGhlIGZvcm1hdHRp bmcuCisKIDIwMTEtMDktMTEgIEphbiBLcmF0b2NodmlsICA8amFuLmtyYXRv Y2h2aWxAcmVkaGF0LmNvbT4KIAogCUNvZGUgY2xlYW51cC4KSW5kZXg6IGdk Yi9wYXJzZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvc3JjL3NyYy9nZGIvcGFyc2UuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4xMTAKZGlmZiAtYSAtcCAtdSAtcjEuMTEwIHBhcnNlLmMKLS0tIGdkYi9w YXJzZS5jCTE3IEp1biAyMDExIDIwOjI0OjIyIC0wMDAwCTEuMTEwCisrKyBn ZGIvcGFyc2UuYwkxMiBTZXAgMjAxMSAxNTowMDoyMyAtMDAwMApAQCAtMTkw LDcgKzE5MCw3IEBAIGZyZWVfZnVuY2FsbHMgKHZvaWQgKmlnbm9yZSkKICAg ICB9CiB9CiAMCi0vKiBUaGlzIHBhZ2UgY29udGFpbnMgdGhlIGZ1bmN0aW9u cyBmb3IgYWRkaW5nIGRhdGEgdG8gdGhlICBzdHJ1Y3QgZXhwcmVzc2lvbgor LyogVGhpcyBwYWdlIGNvbnRhaW5zIHRoZSBmdW5jdGlvbnMgZm9yIGFkZGlu ZyBkYXRhIHRvIHRoZSBzdHJ1Y3QgZXhwcmVzc2lvbgogICAgYmVpbmcgY29u c3RydWN0ZWQuICAqLwogCiAvKiBBZGQgb25lIGVsZW1lbnQgdG8gdGhlIGVu ZCBvZiB0aGUgZXhwcmVzc2lvbi4gICovCkBAIC0xOTksNyArMTk5LDcgQEAg ZnJlZV9mdW5jYWxscyAodm9pZCAqaWdub3JlKQogICAgYSByZWdpc3RlciB0 aHJvdWdoIGhlcmUuICAqLwogCiB2b2lkCi13cml0ZV9leHBfZWx0ICh1bmlv biBleHBfZWxlbWVudCBleHBlbHQpCit3cml0ZV9leHBfZWx0ICh1bmlvbiBl eHBfZWxlbWVudCAqZXhwZWx0KQogewogICBpZiAoZXhwb3V0X3B0ciA+PSBl eHBvdXRfc2l6ZSkKICAgICB7CkBAIC0yMDgsNyArMjA4LDcgQEAgd3JpdGVf ZXhwX2VsdCAodW5pb24gZXhwX2VsZW1lbnQgZXhwZWx0KQogCXhyZWFsbG9j ICgoY2hhciAqKSBleHBvdXQsIHNpemVvZiAoc3RydWN0IGV4cHJlc3Npb24p CiAJCSAgKyBFWFBfRUxFTV9UT19CWVRFUyAoZXhwb3V0X3NpemUpKTsKICAg ICB9Ci0gIGV4cG91dC0+ZWx0c1tleHBvdXRfcHRyKytdID0gZXhwZWx0Owor ICBleHBvdXQtPmVsdHNbZXhwb3V0X3B0cisrXSA9ICpleHBlbHQ7CiB9CiAK IHZvaWQKQEAgLTIxOCw3ICsyMTgsNyBAQCB3cml0ZV9leHBfZWx0X29wY29k ZSAoZW51bSBleHBfb3Bjb2RlIGV4CiAKICAgbWVtc2V0ICgmdG1wLCAwLCBz aXplb2YgKHVuaW9uIGV4cF9lbGVtZW50KSk7CiAgIHRtcC5vcGNvZGUgPSBl eHBlbHQ7Ci0gIHdyaXRlX2V4cF9lbHQgKHRtcCk7CisgIHdyaXRlX2V4cF9l bHQgKCZ0bXApOwogfQogCiB2b2lkCkBAIC0yMjgsNyArMjI4LDcgQEAgd3Jp dGVfZXhwX2VsdF9zeW0gKHN0cnVjdCBzeW1ib2wgKmV4cGVsdAogCiAgIG1l bXNldCAoJnRtcCwgMCwgc2l6ZW9mICh1bmlvbiBleHBfZWxlbWVudCkpOwog ICB0bXAuc3ltYm9sID0gZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXAp OworICB3cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogdm9pZApAQCAtMjM4 LDcgKzIzOCw3IEBAIHdyaXRlX2V4cF9lbHRfYmxvY2sgKHN0cnVjdCBibG9j ayAqYikKIAogICBtZW1zZXQgKCZ0bXAsIDAsIHNpemVvZiAodW5pb24gZXhw X2VsZW1lbnQpKTsKICAgdG1wLmJsb2NrID0gYjsKLSAgd3JpdGVfZXhwX2Vs dCAodG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQK QEAgLTI0OCw3ICsyNDgsNyBAQCB3cml0ZV9leHBfZWx0X29iamZpbGUgKHN0 cnVjdCBvYmpmaWxlICpvCiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2Yg KHVuaW9uIGV4cF9lbGVtZW50KSk7CiAgIHRtcC5vYmpmaWxlID0gb2JqZmls ZTsKLSAgd3JpdGVfZXhwX2VsdCAodG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAo JnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI1OCw3ICsyNTgsNyBAQCB3cml0ZV9l eHBfZWx0X2xvbmdjc3QgKExPTkdFU1QgZXhwZWx0KQogCiAgIG1lbXNldCAo JnRtcCwgMCwgc2l6ZW9mICh1bmlvbiBleHBfZWxlbWVudCkpOwogICB0bXAu bG9uZ2NvbnN0ID0gZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXApOwor ICB3cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogdm9pZApAQCAtMjY4LDcg KzI2OCw3IEBAIHdyaXRlX2V4cF9lbHRfZGJsY3N0IChET1VCTEVTVCBleHBl bHQpCiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9uIGV4cF9l bGVtZW50KSk7CiAgIHRtcC5kb3VibGVjb25zdCA9IGV4cGVsdDsKLSAgd3Jp dGVfZXhwX2VsdCAodG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9 CiAKIHZvaWQKQEAgLTI4MCw3ICsyODAsNyBAQCB3cml0ZV9leHBfZWx0X2Rl Y2Zsb2F0Y3N0IChnZGJfYnl0ZSBleHBlCiAgIGZvciAoaW5kZXggPSAwOyBp bmRleCA8IDE2OyBpbmRleCsrKQogICAgIHRtcC5kZWNmbG9hdGNvbnN0W2lu ZGV4XSA9IGV4cGVsdFtpbmRleF07CiAKLSAgd3JpdGVfZXhwX2VsdCAodG1w KTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI5 MCw3ICsyOTAsNyBAQCB3cml0ZV9leHBfZWx0X3R5cGUgKHN0cnVjdCB0eXBl ICpleHBlbHQpCiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9u IGV4cF9lbGVtZW50KSk7CiAgIHRtcC50eXBlID0gZXhwZWx0OwotICB3cml0 ZV9leHBfZWx0ICh0bXApOworICB3cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0K IAogdm9pZApAQCAtMzAwLDcgKzMwMCw3IEBAIHdyaXRlX2V4cF9lbHRfaW50 ZXJuIChzdHJ1Y3QgaW50ZXJuYWx2YXIKIAogICBtZW1zZXQgKCZ0bXAsIDAs IHNpemVvZiAodW5pb24gZXhwX2VsZW1lbnQpKTsKICAgdG1wLmludGVybmFs dmFyID0gZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3cml0 ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogLyogQWRkIGEgc3RyaW5nIGNvbnN0 YW50IHRvIHRoZSBlbmQgb2YgdGhlIGV4cHJlc3Npb24uCkluZGV4OiBzaW0v cHBjL2RwLWJpdC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvc3JjL3NyYy9zaW0vcHBjL2RwLWJpdC5jLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjcKZGlmZiAtYSAtcCAtdSAtcjEuNyBkcC1iaXQuYwotLS0g c2ltL3BwYy9kcC1iaXQuYwkxIEphbiAyMDExIDE1OjM0OjA0IC0wMDAwCTEu NworKysgc2ltL3BwYy9kcC1iaXQuYwkxMiBTZXAgMjAxMSAxNTowMDoyNiAt MDAwMApAQCAtNDA4LDcgKzQwOCw3IEBAIHBhY2tfZCAoIGZwX251bWJlcl90 eXBlICogIHNyYykKIH0KIAogc3RhdGljIHZvaWQKLXVucGFja19kIChGTE9f dW5pb25fdHlwZSAqIHNyYywgZnBfbnVtYmVyX3R5cGUgKiBkc3QpCit1bnBh Y2tfZCAoRkxPX3VuaW9uX3R5cGUgKnNyYywgZnBfbnVtYmVyX3R5cGUgKmRz dCkKIHsKICAgZnJhY3R5cGUgZnJhY3Rpb24gPSBzcmMtPmJpdHMuZnJhY3Rp b247CiAK --0016364d2c7965a8ac04acbfddf0--