From: Abhijit Halder <abhijit.k.halder@gmail.com>
To: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PR-10034 Bad space handling in set remote exec-file command
Date: Mon, 26 Sep 2011 05:41:00 -0000 [thread overview]
Message-ID: <CAOhZP9x4yFXWfLaCy93YOhKjbkZQJFNEx0VRW-ZK18unA=jM1g@mail.gmail.com> (raw)
In-Reply-To: <CAOhZP9zCT7iSs9Owi1+eBVHDrGLO8fPj4m62LSwa6FV-g-3FhA@mail.gmail.com>
On Sun, Sep 25, 2011 at 2:21 PM, Abhijit Halder
<abhijit.k.halder@gmail.com> wrote:
> Hi,
>
> In the set remote exec-file command if we provide space at the end of
> the file-name the space is not being cleared. This behaviour is
> inconsistent across similar set commands like set logging file etc. My
> patch will fix that behaviour. Please review this patch.
>
> Further, I have found that there is a function in cli/cli-utils.c
> called remove_trailing_whitespace that never used. In many times we
> have removed trailing spaces and for that inline code is written. In
> my next patch I am planning to modify the remove_trailing_whitespace
> function and use it whenever possible in that. Since that patch will
> be relevant to current fix I am proposing, I have mentioned here that
> point.
>
> Thanks,
> Abhijit Halder
>
Oops! A mistake. Correcting the same.
next prev parent reply other threads:[~2011-09-26 5:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 10:18 Abhijit Halder
2011-09-26 5:41 ` Abhijit Halder [this message]
2011-09-26 16:01 ` Abhijit Halder
2011-09-29 8:27 ` Abhijit Halder
2011-10-02 8:14 [PATCH] PR-10034 Bad space handling in `set remote exec-file' command Abhijit Halder
2011-10-04 15:51 ` Tom Tromey
2011-10-05 4:19 ` Abhijit Halder
2011-10-05 14:01 ` Tom Tromey
2011-10-14 9:53 ` Abhijit Halder
2011-10-14 11:47 ` Abhijit Halder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOhZP9x4yFXWfLaCy93YOhKjbkZQJFNEx0VRW-ZK18unA=jM1g@mail.gmail.com' \
--to=abhijit.k.halder@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox