From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29121 invoked by alias); 26 Sep 2011 05:22:22 -0000 Received: (qmail 29108 invoked by uid 22791); 26 Sep 2011 05:22:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gy0-f169.google.com (HELO mail-gy0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Sep 2011 05:22:06 +0000 Received: by gya6 with SMTP id 6so4610156gya.0 for ; Sun, 25 Sep 2011 22:22:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.29.228 with SMTP id n4mr27748294pbh.64.1317014525649; Sun, 25 Sep 2011 22:22:05 -0700 (PDT) Received: by 10.143.147.12 with HTTP; Sun, 25 Sep 2011 22:22:05 -0700 (PDT) In-Reply-To: References: Date: Mon, 26 Sep 2011 05:41:00 -0000 Message-ID: Subject: Re: [PATCH] PR-10034 Bad space handling in set remote exec-file command From: Abhijit Halder To: "gdb-patches@sourceware.org ml" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00443.txt.bz2 On Sun, Sep 25, 2011 at 2:21 PM, Abhijit Halder wrote: > Hi, > > In the set remote exec-file command if we provide space at the end of > the file-name the space is not being cleared. This behaviour is > inconsistent across similar set commands like set logging file etc. My > patch will fix that behaviour. Please review this patch. > > Further, I have found that there is a function in cli/cli-utils.c > called remove_trailing_whitespace that never used. In many times we > have removed trailing spaces and for that inline code is written. In > my next patch I am planning to modify the remove_trailing_whitespace > function and use it whenever possible in that. Since that patch will > be relevant to current fix I am proposing, I have mentioned here that > point. > > Thanks, > Abhijit Halder > Oops! A mistake. Correcting the same.