From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Python API: Fix an exception when registering a global pretty-printer in verbose mode
Date: Wed, 11 Mar 2015 18:05:00 -0000 [thread overview]
Message-ID: <CAOKbPbbvM68RZb+C=Ak=YMYDTo9-ARNH+M6btMhVTfbEiQed6g@mail.gmail.com> (raw)
In-Reply-To: <CADPb22RmooRYwu2vYc3mAZ90H=p8+6ri1K8BcwDUFk1QEwSQRg@mail.gmail.com>
On Wed, Mar 11, 2015 at 2:59 PM, Doug Evans <dje@google.com> wrote:
> LGTM with one nit:
> I suspect the patch as is will go past our 80 character hard limit.
> [Though PEP008 has a 79 character limit ... yay.]
> While in C we would put the '%' on the next line, I think we follow
> the opposite convention in python. That's what the surrounding
> code does anyway, so move printer.name to the next line.
Will do.
prev parent reply other threads:[~2015-03-11 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 17:37 Martin Galvan
2015-03-11 17:59 ` Doug Evans
2015-03-11 18:05 ` Martin Galvan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOKbPbbvM68RZb+C=Ak=YMYDTo9-ARNH+M6btMhVTfbEiQed6g@mail.gmail.com' \
--to=martin.galvan@tallertechnologies.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox