From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34335 invoked by alias); 11 Mar 2015 18:05:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34300 invoked by uid 89); 11 Mar 2015 18:05:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f47.google.com Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Mar 2015 18:05:46 +0000 Received: by labgq15 with SMTP id gq15so10644641lab.1 for ; Wed, 11 Mar 2015 11:05:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=EDTYJgzbEmkALVLxkOq4DhypmJysapnUeJfVfAuImrM=; b=nCCKrzMwbNAhNPjN/OXcFEfhyY2GlvYDjht9ga79GP+8seYQJ7XaaZzXU3EYAz0hoy XzvPn/UDMazt3jYH9D7wXOkmyh8AQ3JEO6Y1QZ43meseeGex7PLEwYMjBLh34cUur2C2 X3/icCPfZ7oGmRXmwAUhHC9hhV3IlDPHBoddYYk6hDJMEwSZc9uRA+Im0M1W94FTnoPs Qb8z8jRVgJnshDrB1bKG9gie3gst20mslG3EiHm2mw5koOwL/EUBfgL4zfrlEduYq6Pn XquFVg2XK9WqCVh6s4FhEvo++X19BqkJMAI5/F8perFu2HKuR+tIx6MaJF/+TDkTiUEB bZ3g== X-Gm-Message-State: ALoCoQmaFBoYUBT+CwdWHpx02/0p/GdiRnbOX8etLmoAH0KKPY8biz8B+nUy46tn58Iqls9zY2Pz X-Received: by 10.112.44.132 with SMTP id e4mr35370449lbm.66.1426097143078; Wed, 11 Mar 2015 11:05:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.52.42 with HTTP; Wed, 11 Mar 2015 11:05:02 -0700 (PDT) In-Reply-To: References: <1426095417-22764-1-git-send-email-martin.galvan@tallertechnologies.com> From: Martin Galvan Date: Wed, 11 Mar 2015 18:05:00 -0000 Message-ID: Subject: Re: [PATCH] Python API: Fix an exception when registering a global pretty-printer in verbose mode To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-03/txt/msg00309.txt.bz2 On Wed, Mar 11, 2015 at 2:59 PM, Doug Evans wrote: > LGTM with one nit: > I suspect the patch as is will go past our 80 character hard limit. > [Though PEP008 has a 79 character limit ... yay.] > While in C we would put the '%' on the next line, I think we follow > the opposite convention in python. That's what the surrounding > code does anyway, so move printer.name to the next line. Will do.