Re: [PATCH v3][PR gdb/19893] Fix handling of synthetic C++ references

[Martin Galvan <martin.galvan@tallertechnologies.com>]

On Tue, May 31, 2016 at 11:23 AM, Pedro Alves <palves@redhat.com> wrote:
> On 05/31/2016 03:13 PM, Pedro Alves wrote:
>
>> Otherwise OK.  Please push.
>
> Actually, I take that back, sorry.  I forgot something:
>
>>> +     Notice that for references to TYPE_CODE_STRUCT, 'set print object on' will
>>> +     cause original_value to be a not_lval instead of an lval_computed,
>>> +     which will make value_bits_synthetic_pointer return false.
>
> I still think it'd be very good to have this covered
> with a test.
>
> I think it should be a matter of wrapping the printing
> part of new tests (maybe only implref-struct.exp, not sure), with:
>
> foreach_with_prefix print-object {"off" "off"} {
>    gdb_test_no_output "set print object ${print-object}"
>
>    ... ref printing tests ...
> }
>
> Could you do that please?
>
> Thanks,
> Pedro Alves
>

Sure. Yeah, I completely missed that. I'll add the test and send in v4
to make it official.

Thanks for the patience! It's great to finally see this go in.