From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131849-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 118352 invoked by alias); 31 May 2016 14:25:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 118339 invoked by uid 89); 31 May 2016 14:25:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qg0-f48.google.com
Received: from mail-qg0-f48.google.com (HELO mail-qg0-f48.google.com) (209.85.192.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 31 May 2016 14:25:41 +0000
Received: by mail-qg0-f48.google.com with SMTP id e93so91942000qgf.2        for <gdb-patches@sourceware.org>; Tue, 31 May 2016 07:25:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=dSykZVQI4qdFJT0hzY2Mky6VxK544MYXeiQUevcjMcs=;        b=dhUN7D8z6lERN+/Ls10vEZ0JGRlD4DPykro2JeW1rhlgDZHTY9lgwDgv+npXN+ggBx         rLW43Hgau0o50WGPDqZ3SyGa9FbRALtKFl+3ug1UjnJY7jIum6if3xu66D82c3evdiXX         pAncmxJbUkJPGu9nC3UOcs0Xk8PtzaNupaECqYG8+lVDCiGj7J6kz0xBT+2/VtRucMzu         +3quRfhMQb38nSMfBcsP3drxmT31e7qopGIxnZwEFlxj2QdDdAL/njxy1mTrfAatc/zE         O+jAbaGawytdyrBKv0BdursxI6osCzV8VQxTtoCOVPA923O/CJE8uOo4a102gSZcGz7g         6cAA==
X-Gm-Message-State: ALyK8tJC1viFkWyqF8Oy8CVbEVnsx4Se2QCnTsFklDZZnZGO3MDkcW72URkTZyKj9NW+4X+2iC/S//LhgHO324nB
X-Received: by 10.140.99.109 with SMTP id p100mr30085466qge.97.1464704739217; Tue, 31 May 2016 07:25:39 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.55.24.150 with HTTP; Tue, 31 May 2016 07:24:59 -0700 (PDT)
In-Reply-To: <67dc8b18-2006-4309-4b18-4c8080e89250@redhat.com>
References: <20160530194057.13511-1-martin.galvan@tallertechnologies.com> <f304ad49-fe80-c7f3-bf4c-71aed85e2429@redhat.com> <67dc8b18-2006-4309-4b18-4c8080e89250@redhat.com>
From: Martin Galvan <martin.galvan@tallertechnologies.com>
Date: Tue, 31 May 2016 14:25:00 -0000
Message-ID: <CAOKbPbas5z=d_v4NYYNX0vdEbAvUZzP9OPXVYXrEAGZFt35UpA@mail.gmail.com>
Subject: Re: [PATCH v3][PR gdb/19893] Fix handling of synthetic C++ references
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2016-05/txt/msg00555.txt.bz2

On Tue, May 31, 2016 at 11:23 AM, Pedro Alves <palves@redhat.com> wrote:
> On 05/31/2016 03:13 PM, Pedro Alves wrote:
>
>> Otherwise OK.  Please push.
>
> Actually, I take that back, sorry.  I forgot something:
>
>>> +     Notice that for references to TYPE_CODE_STRUCT, 'set print object on' will
>>> +     cause original_value to be a not_lval instead of an lval_computed,
>>> +     which will make value_bits_synthetic_pointer return false.
>
> I still think it'd be very good to have this covered
> with a test.
>
> I think it should be a matter of wrapping the printing
> part of new tests (maybe only implref-struct.exp, not sure), with:
>
> foreach_with_prefix print-object {"off" "off"} {
>    gdb_test_no_output "set print object ${print-object}"
>
>    ... ref printing tests ...
> }
>
> Could you do that please?
>
> Thanks,
> Pedro Alves
>

Sure. Yeah, I completely missed that. I'll add the test and send in v4
to make it official.

Thanks for the patience! It's great to finally see this go in.